From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FF1C433B4 for ; Sat, 15 May 2021 21:03:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC82161353 for ; Sat, 15 May 2021 21:03:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235046AbhEOVEM (ORCPT ); Sat, 15 May 2021 17:04:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbhEOVEJ (ORCPT ); Sat, 15 May 2021 17:04:09 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DAEEC061573; Sat, 15 May 2021 14:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hyyxptrN6opDfMyDe82jUzcLX0UK5gBJjKQrYKblEk0=; b=EQfXeu58xeH/wF2c62hm+Hpm+D llBIBgZ4UtGnuztEh0gmSWjIv1tcLsdI5waiS+I6gSU6yAaUzD1XUM3FuaBj/C9Sl8u9yeaqcYgP6 J0dS3fJPx+9H9r+6n63o8YiSNP/CwbTYB4U2fzBgYYICn3+WZLDl/e35s+shaUWpEQTTkR1AE8she Hp5FLL88GPsErt9Ut85nULimIJCc6raoa0KrbLYzOjMABU4wDVWZ2kammutEnvTiqke6EL3TF249o EDz6njNYUOtIMxraQ1hVDi6uYV8KfBX4JkJihG6if7PhAtZbxmyTV4V7J5/dWVQjdiV1TQnF3pE2+ 85x6T6Lw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1li1Qn-00Azjf-5i; Sat, 15 May 2021 21:02:41 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 63E5E98659E; Sat, 15 May 2021 23:02:38 +0200 (CEST) Date: Sat, 15 May 2021 23:02:38 +0200 From: Peter Zijlstra To: Khaled ROMDHANI Cc: mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH-next] sched: Fix Null pointer derefrence Message-ID: <20210515210238.GG5618@worktop.programming.kicks-ass.net> References: <20210515164645.22849-1-khaledromdhani216@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210515164645.22849-1-khaledromdhani216@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 15, 2021 at 05:46:45PM +0100, Khaled ROMDHANI wrote: > The 'curr' variable could be NULL and derefrenced by > pick_next_entity. Fix this by adding a check that prevent > the invocation of pick_next_entity with a NULL passed argument. And why exactly is that a problem?