From: "Paul E. McKenney" <paulmck@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, ming.lei@redhat.com, riel@fb.com,
jweiner@fb.com, cl@linux.com, penberg@kernel.org,
rientjes@google.com, iamjoonsoo.kim@lge.com, glittao@gmail.com
Subject: Re: [BUG] Shudown-time lockdep splat in next-20210514
Date: Sat, 15 May 2021 16:19:26 -0700 [thread overview]
Message-ID: <20210515231926.GB4441@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <a9e5c5c4-08db-47bf-cb0a-2a90bd747c77@suse.cz>
On Sat, May 15, 2021 at 11:09:13PM +0200, Vlastimil Babka wrote:
> On 5/15/21 10:46 PM, Paul E. McKenney wrote:
> > Hello!
> >
> > I am seeing the following lockdep splat in next-20210514. It happens
> > at shutdown time in all rcutorture scenarios that enable lockdep. It
> > happens consistently on 2-hour runs, and I am trying it on shorter runs.
> > If it reproduces nicely, I will try bisection.
> >
> > In the meantime, does this ring a bell for anyone?
>
> Hm, I think it will be
> ad36bafb3bcdf mm/slub: use stackdepot to save stack trace in objects
>
> can you try this please?
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 6b896b8c36f0..04824dae2e32 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -623,7 +623,7 @@ static void set_track(struct kmem_cache *s, void *object,
>
> if (addr) {
> #ifdef CONFIG_STACKDEPOT
> - p->handle = save_stack_depot_trace(GFP_KERNEL);
> + p->handle = save_stack_depot_trace(GFP_NOWAIT);
> #endif
> p->addr = addr;
> p->cpu = smp_processor_id();
Works like a charm!
Tested-by: Paul E. McKenney <paulmck@kernel.org>
Thanx, Paul
prev parent reply other threads:[~2021-05-15 23:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 20:46 [BUG] Shudown-time lockdep splat in next-20210514 Paul E. McKenney
2021-05-15 21:09 ` Vlastimil Babka
2021-05-15 23:19 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210515231926.GB4441@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=glittao@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jweiner@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ming.lei@redhat.com \
--cc=penberg@kernel.org \
--cc=riel@fb.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).