From: Xie Yongji <xieyongji@bytedance.com>
To: mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com
Cc: amit@kernel.org, arei.gonglei@huawei.com, airlied@linux.ie,
kraxel@redhat.com, dan.j.williams@intel.com,
johannes@sipsolutions.net, ohad@wizery.com,
bjorn.andersson@linaro.org, david@redhat.com, vgoyal@redhat.com,
miklos@szeredi.hu, sgarzare@redhat.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH 00/17] Add validation for used length
Date: Mon, 17 May 2021 17:08:19 +0800 [thread overview]
Message-ID: <20210517090836.533-1-xieyongji@bytedance.com> (raw)
Current virtio device drivers may trust the used length returned
in virtqueue_get_buf()/virtqueue_get_buf_ctx(). But the used length
might come from an untrusted device when VDUSE[1] is enabled. To
protect this case, this series tries to add validation for the
used length.
Since many legacy devices will also set the used length incorrectly,
we did not add the validation unconditionally. Instead, we will do
the validation only when the device driver needs the used length.
A NULL len passed to virtqueue_get_buf()/virtqueue_get_buf_ctx()
will mean the used length is not needed by the device driver.
[1] https://lore.kernel.org/kvm/20210331080519.172-1-xieyongji@bytedance.com/
Xie Yongji (17):
virtio_ring: Avoid reading unneeded used length
virtio-blk: Remove unused used length
virtio_console: Remove unused used length
crypto: virtio - Remove unused used length
drm/virtio: Remove unused used length
caif_virtio: Remove unused used length
virtio_net: Remove unused used length
mac80211_hwsim: Remove unused used length
virtio_pmem: Remove unused used length
rpmsg: virtio: Remove unused used length
virtio_scsi: Remove unused used length
virtio_balloon: Remove unused used length
virtio_input: Remove unused used length
virtio_mem: Remove unused used length
virtiofs: Remove unused used length
vsock: Remove unused used length
virtio_ring: Add validation for used length
drivers/block/virtio_blk.c | 3 +--
drivers/char/virtio_console.c | 12 ++++--------
drivers/crypto/virtio/virtio_crypto_algs.c | 6 ++----
drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +--
drivers/net/caif/caif_virtio.c | 3 +--
drivers/net/virtio_net.c | 10 ++++------
drivers/net/wireless/mac80211_hwsim.c | 3 +--
drivers/nvdimm/nd_virtio.c | 3 +--
drivers/rpmsg/virtio_rpmsg_bus.c | 3 +--
drivers/scsi/virtio_scsi.c | 3 +--
drivers/virtio/virtio_balloon.c | 21 ++++++++++-----------
drivers/virtio/virtio_input.c | 6 ++----
drivers/virtio/virtio_mem.c | 3 +--
drivers/virtio/virtio_ring.c | 28 +++++++++++++++++++++++-----
fs/fuse/virtio_fs.c | 6 ++----
net/vmw_vsock/virtio_transport.c | 3 +--
16 files changed, 56 insertions(+), 60 deletions(-)
--
2.11.0
next reply other threads:[~2021-05-17 9:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 9:08 Xie Yongji [this message]
2021-05-17 9:08 ` [RFC PATCH 01/17] virtio_ring: Avoid reading unneeded used length Xie Yongji
2021-05-17 9:11 ` Johannes Berg
2021-05-17 9:41 ` Yongji Xie
2021-05-17 9:08 ` [RFC PATCH 02/17] virtio-blk: Remove unused " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 03/17] virtio_console: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 04/17] crypto: virtio - " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 05/17] drm/virtio: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 06/17] caif_virtio: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 07/17] virtio_net: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 08/17] mac80211_hwsim: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 09/17] virtio_pmem: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 10/17] rpmsg: virtio: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 11/17] virtio_scsi: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 12/17] virtio_balloon: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 13/17] virtio_input: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 14/17] virtio_mem: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 15/17] virtiofs: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 16/17] vsock: " Xie Yongji
2021-05-17 9:08 ` [RFC PATCH 17/17] virtio_ring: Add validation for " Xie Yongji
2021-05-17 23:39 ` Michael S. Tsirkin
2021-05-25 1:31 ` Jason Wang
2021-05-25 5:08 ` Yongji Xie
2021-05-17 23:40 ` [RFC PATCH 00/17] " Michael S. Tsirkin
2021-05-18 8:29 ` Yongji Xie
2021-05-18 9:52 ` Michael S. Tsirkin
2021-05-18 12:28 ` Yongji Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517090836.533-1-xieyongji@bytedance.com \
--to=xieyongji@bytedance.com \
--cc=airlied@linux.ie \
--cc=amit@kernel.org \
--cc=arei.gonglei@huawei.com \
--cc=bjorn.andersson@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jasowang@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mst@redhat.com \
--cc=ohad@wizery.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).