From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C99B7C433B4 for ; Mon, 17 May 2021 10:55:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B05F7611C2 for ; Mon, 17 May 2021 10:55:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236598AbhEQK4a (ORCPT ); Mon, 17 May 2021 06:56:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236556AbhEQK41 (ORCPT ); Mon, 17 May 2021 06:56:27 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D397C061573; Mon, 17 May 2021 03:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/jXKRvEAGHf4XcoVw2En2iOfrxY4eQ22yvfNze/jORc=; b=lqRFR80I/wSPtHYniW1bDyEUf cUrsWt0HhhyqUWfhPPBnUvFm8Eki/Z25W8/fBog//DEmgWyVPtEDcT2EQJDBjAE99yRG8uZONXwC1 xo153AxgP/6c7ejMd2dWgtsbEDTG1DGQTxUvc+26zHmsRR6MJmz/yknSly84bMdz8RLxOVpXc5utZ beYdwnC6JwOs8ZrZnz1VIXQPQ8kNflGlZqImlC7vcQeOj0v5P47JGRbNqpSJc6PKKiUv8u/tiRdof k954LYDr6WpuIg0fBhub1a8aXk8Yo+WZTSPxFXo75chhgvUx02SKd1/9BR5vHNWBF0khhIZnrI/Zd tK0xR2UMw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44096) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liatI-0002KM-FV; Mon, 17 May 2021 11:54:28 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1liatE-0006st-Fw; Mon, 17 May 2021 11:54:24 +0100 Date: Mon, 17 May 2021 11:54:24 +0100 From: "Russell King (Oracle)" To: Michael Sit Wei Hong Cc: Jose.Abreu@synopsys.com, andrew@lunn.ch, hkallweit1@gmail.com, kuba@kernel.org, netdev@vger.kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, davem@davemloft.net, mcoquelin.stm32@gmail.com, weifeng.voon@intel.com, boon.leong.ong@intel.com, tee.min.tan@intel.com, vee.khee.wong@linux.intel.com, vee.khee.wong@intel.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: stmmac: Add callbacks for DWC xpcs Energy Efficient Ethernet Message-ID: <20210517105424.GP12395@shell.armlinux.org.uk> References: <20210517094332.24976-1-michael.wei.hong.sit@intel.com> <20210517094332.24976-3-michael.wei.hong.sit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210517094332.24976-3-michael.wei.hong.sit@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 17, 2021 at 05:43:32PM +0800, Michael Sit Wei Hong wrote: > Link xpcs callback functions for MAC to configure the xpcs EEE feature. > > The clk_eee frequency is used to calculate the MULT_FACT_100NS. This is > to adjust the clock tic closer to 100ns. > > Signed-off-by: Michael Sit Wei Hong What is the initial state of the EEE configuration before the first call to stmmac_ethtool_op_set_eee()? Does it reflect the default EEE settings? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!