From: Oscar Salvador <osalvador@suse.de>
To: Naoya Horiguchi <nao.horiguchi@gmail.com>
Cc: Muchun Song <songmuchun@bytedance.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Michal Hocko <mhocko@suse.com>, Tony Luck <tony.luck@intel.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] mm,hwpoison: make get_hwpoison_page call get_any_page()
Date: Mon, 17 May 2021 14:59:03 +0200 [thread overview]
Message-ID: <20210517125859.GA25228@linux> (raw)
In-Reply-To: <20210517045401.2506032-3-nao.horiguchi@gmail.com>
On Mon, May 17, 2021 at 01:54:01PM +0900, Naoya Horiguchi wrote:
> static int __get_hwpoison_page(struct page *page)
> {
> struct page *head = compound_head(page);
> @@ -1098,7 +1091,9 @@ static int __get_hwpoison_page(struct page *page)
>
> #ifdef CONFIG_HUGETLB_PAGE
> spin_lock(&hugetlb_lock);
> - if (PageHuge(head) && (HPageFreed(head) || HPageMigratable(head)))
> + if (!PageHuge(head))
> + ret = -EBUSY;
Unless I'm missing something, we will be returning -EBUSY for any non-hugetlb
page, which is not right.
I think what you want is to return -EBUSY in case the page is a hugetlb page
but we cannot grab a refcount because the page is in a floating state, meaning
!HPageFreed && !HPageMigratable.
Right?
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2021-05-17 12:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 4:53 [PATCH v4 0/2] hwpoison: fix race with compound page allocation Naoya Horiguchi
2021-05-17 4:54 ` [PATCH v4 1/2] mm,hwpoison: " Naoya Horiguchi
2021-05-17 10:12 ` Oscar Salvador
2021-05-17 11:34 ` Naoya Horiguchi
2021-05-17 20:11 ` Mike Kravetz
2021-05-18 5:24 ` HORIGUCHI NAOYA(堀口 直也)
2021-05-17 4:54 ` [PATCH v4 2/2] mm,hwpoison: make get_hwpoison_page call get_any_page() Naoya Horiguchi
2021-05-17 12:59 ` Oscar Salvador [this message]
2021-05-17 15:13 ` HORIGUCHI NAOYA(堀口 直也)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517125859.GA25228@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=nao.horiguchi@gmail.com \
--cc=naoya.horiguchi@nec.com \
--cc=songmuchun@bytedance.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).