From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Vidya Sagar <vidyas@nvidia.com>,
robh@kernel.org, bhelgaas@google.com, thierry.reding@gmail.com,
jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, kthota@nvidia.com,
mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH] PCI: tegra: Fix host initialization during resume
Date: Mon, 17 May 2021 17:18:36 +0100 [thread overview]
Message-ID: <20210517161835.GA9796@lpieralisi> (raw)
In-Reply-To: <7dbc7daf-5512-c938-3aee-3c1994b50d07@nvidia.com>
On Mon, May 17, 2021 at 03:11:00PM +0100, Jon Hunter wrote:
> Hi Lorenzo, Bjorn,
>
> On 06/05/2021 09:49, Jon Hunter wrote:
> >
> > On 04/05/2021 18:21, Vidya Sagar wrote:
> >> Commit 275e88b06a27 ("PCI: tegra: Fix host link initialization") broke
> >> host initialization during resume as it misses out calling the API
> >> dw_pcie_setup_rc() which is required for host and MSI initialization.
> >>
> >> Fixes: 275e88b06a27 ("PCI: tegra: Fix host link initialization")
> >> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> >> ---
> >> drivers/pci/controller/dwc/pcie-tegra194.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> >> index 6fa216e52d14..4c3c0738f2e6 100644
> >> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> >> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> >> @@ -2214,6 +2214,8 @@ static int tegra_pcie_dw_resume_noirq(struct device *dev)
> >> goto fail_host_init;
> >> }
> >>
> >> + dw_pcie_setup_rc(&pcie->pci.pp);
> >> +
> >> ret = tegra_pcie_dw_start_link(&pcie->pci);
> >> if (ret < 0)
> >> goto fail_host_init;
> >>
> >
> >
> > Thanks for fixing!
> >
> > Tested-by: Jon Hunter <jonathanh@nvidia.com>
> >
> > We should also mark this for stable so that this gets back-ported.
>
>
> Can we queue this as a fix for v5.13 and tag for stable?
We usually send fixes for -rc* when the patches they are fixing
were merged in the current cycle (ie merged for v5.13).
This is not the case so I shall send it for v5.14.
Lorenzo
next prev parent reply other threads:[~2021-05-17 16:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 17:21 [PATCH] PCI: tegra: Fix host initialization during resume Vidya Sagar
2021-05-06 8:49 ` Jon Hunter
2021-05-17 14:11 ` Jon Hunter
2021-05-17 16:18 ` Lorenzo Pieralisi [this message]
2021-05-17 16:47 ` Bjorn Helgaas
2021-05-17 17:41 ` Jon Hunter
2021-06-03 14:21 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517161835.GA9796@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=robh@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).