From: Lucas Stankus <lucas.p.stankus@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
fabioaiuto83@gmail.com
Subject: Re: [PATCH 1/2] staging: iio: cdc: ad7746: clean up driver comments and probe return
Date: Mon, 17 May 2021 21:43:22 -0300 [thread overview]
Message-ID: <20210518004322.v2hshj2xzj37vgmg@smtp.gmail.com> (raw)
In-Reply-To: <20210513170012.78326bfa@jic23-huawei>
On Thu, May 13, 2021 at 12:59 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Tue, 11 May 2021 17:54:01 -0300
> Lucas Stankus <lucas.p.stankus@gmail.com> wrote:
>
> > Remove vague comments, align temperature comment with indent block and
> > simplify probe return on device register.
> >
> > Also fix the following checkpatch warning:
> > CHECK: Alignment should match open parenthesis
> >
> > Signed-off-by: Lucas Stankus <lucas.p.stankus@gmail.com>
>
> As Fabio pointed out, finer grained patches with one type of change per
> patch would be good.
Thank you both for the review and sorry for the radio silence, I'll split
the patch in the v2.
>
> > ---
> > drivers/staging/iio/cdc/ad7746.c | 31 ++++++++++---------------------
> > 1 file changed, 10 insertions(+), 21 deletions(-)
> >
> > diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> > index dfd71e99e872..e03d010b2f4c 100644
> > --- a/drivers/staging/iio/cdc/ad7746.c
> > +++ b/drivers/staging/iio/cdc/ad7746.c
> > @@ -84,10 +84,6 @@
> > #define AD7746_CAPDAC_DACEN BIT(7)
> > #define AD7746_CAPDAC_DACP(x) ((x) & 0x7F)
> >
> > -/*
> > - * struct ad7746_chip_info - chip specific information
> > - */
> > -
> > struct ad7746_chip_info {
> > struct i2c_client *client;
> > struct mutex lock; /* protect sensor state */
> > @@ -232,13 +228,14 @@ static int ad7746_select_channel(struct iio_dev *indio_dev,
> >
> > if (chip->capdac_set != chan->channel) {
> > ret = i2c_smbus_write_byte_data(chip->client,
> > - AD7746_REG_CAPDACA,
> > - chip->capdac[chan->channel][0]);
> > + AD7746_REG_CAPDACA,
> > + chip->capdac[chan->channel][0]);
> > if (ret < 0)
> > return ret;
> > + ret = i2c_smbus_write_byte_data(chip->client,
> > - AD7746_REG_CAPDACB,
> > - chip->capdac[chan->channel][1]);
> > + AD7746_REG_CAPDACB,
> > + chip->capdac[chan->channel][1]);
> > if (ret < 0)
> > return ret;
>
> I wondered if it might be sensible to factor this code out to reduce the indent
> and make things more readable. Having taken a look it seems there is another
> place with exactly the same call sequence. From how it's used there, I'm
> assuming this is updating the offsets. As such, I would introduce an
>
> ad7746_offsets_set(struct iio_dev *indio_dev, int channel)
>
> or similar.
>
Makes sense, I'll do that in the v2 as well.
>
> >
> > @@ -564,10 +561,10 @@ static int ad7746_read_raw(struct iio_dev *indio_dev,
> >
> > switch (chan->type) {
> > case IIO_TEMP:
> > - /*
> > - * temperature in milli degrees Celsius
> > - * T = ((*val / 2048) - 4096) * 1000
> > - */
> > + /*
> > + * temperature in milli degrees Celsius
> > + * T = ((*val / 2048) - 4096) * 1000
> > + */
> > *val = (*val * 125) / 256;
> > break;
> > case IIO_VOLTAGE:
> > @@ -669,10 +666,6 @@ static const struct iio_info ad7746_info = {
> > .write_raw = ad7746_write_raw,
> > };
> >
> > -/*
> > - * device probe and remove
> > - */
> > -
> > static int ad7746_probe(struct i2c_client *client,
> > const struct i2c_device_id *id)
> > {
> > @@ -730,11 +723,7 @@ static int ad7746_probe(struct i2c_client *client,
> > if (ret < 0)
> > return ret;
> >
> > - ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev);
> > - if (ret)
> > - return ret;
> > -
> > - return 0;
> > + return devm_iio_device_register(indio_dev->dev.parent, indio_dev);
> > }
> >
> > static const struct i2c_device_id ad7746_id[] = {
>
next prev parent reply other threads:[~2021-05-18 0:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 20:53 [PATCH 0/2] staging: iio: cdc: ad7746: initial effort to move out of staging Lucas Stankus
2021-05-11 20:54 ` [PATCH 1/2] staging: iio: cdc: ad7746: clean up driver comments and probe return Lucas Stankus
2021-05-12 7:45 ` Fabio Aiuto
2021-05-13 16:00 ` Jonathan Cameron
2021-05-18 0:43 ` Lucas Stankus [this message]
2021-05-11 20:54 ` [PATCH 2/2] staging: iio: cdc: ad7746: avoid overwrite of num_channels Lucas Stankus
2021-05-12 17:20 ` Alexandru Ardelean
2021-05-13 15:52 ` Jonathan Cameron
2021-05-18 0:49 ` Lucas Stankus
2021-05-18 0:55 ` Lucas Stankus
2021-05-18 12:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518004322.v2hshj2xzj37vgmg@smtp.gmail.com \
--to=lucas.p.stankus@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).