From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78212C433B4 for ; Tue, 18 May 2021 12:25:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BE536124C for ; Tue, 18 May 2021 12:25:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349038AbhERM00 (ORCPT ); Tue, 18 May 2021 08:26:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349022AbhERM0Y (ORCPT ); Tue, 18 May 2021 08:26:24 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD7A3C061756 for ; Tue, 18 May 2021 05:25:04 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id 10so7282241pfl.1 for ; Tue, 18 May 2021 05:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heitbaum.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=V+Bd/HFaeS1GNwMmANHqZIk69m3dVyRb6nibgfR29Gg=; b=JAJGPK1PUvnJdKX9L6nSJm/44fQnfhSjBtGR/eLFxmr9GjIbztv+NqP5KN5i7i3zkR f9+0yJ+6rkJnkaz3Jr1KNgXrvvHZAa+uMhhmUA3I1hSMbgzCgZ9WmTIZ8KPE5w+YZL15 wcORdvPps6Tzsyfq8ge1cxORSdBDJuN1nft5c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=V+Bd/HFaeS1GNwMmANHqZIk69m3dVyRb6nibgfR29Gg=; b=QG3+rdPs3FU6q2RRGe0fub/E1RD123di26W711kRhiKQiS1+Q7/CF3+h4BMdOg8H4E moPdScRCPgaLErpVWLuo2Hpz/5wgbW51jc1TMe6LF7lMMLsdoJEoxe8Nde/Fg5kIS3X4 errZA/bqrP2s80/48R5bIWNJsBb09ZaT0yOE26XfcDgD6RqByqHIWejbvFWoXqJ67D1K 2PrSfNAtc5c3mLeLrdVC91DeeGD2Yldnnl+4L69iBlxVUd5VPekY6nACBY0Bk3ZZN+tG H/SOYM09mZdNfdrDAu4B/p9FEv4XgaxeVTkXw8N5ZTXZeyuULhDymbSCJjnSGtNU3HVk ERzA== X-Gm-Message-State: AOAM530w+YrcIAOEPBN9LrMbLJvJf+nfDs2TNL2DCS3Y2ODRucjgdWci 49GbJgR0UFNe2JZd1Ghz7ctt27v8UyvS+ofpaHU= X-Google-Smtp-Source: ABdhPJwRNU3BebEPYvQ2pZsl6/7bRaWW2Ba8dXgU325Ki5n+AdladpPyO4U2cmf4gCuUtdz8wTtI6A== X-Received: by 2002:a62:7ad4:0:b029:2dc:d1a2:b093 with SMTP id v203-20020a627ad40000b02902dcd1a2b093mr4783347pfc.66.1621340704231; Tue, 18 May 2021 05:25:04 -0700 (PDT) Received: from ec3d6f83b95b (110-175-118-133.tpgi.com.au. [110.175.118.133]) by smtp.gmail.com with ESMTPSA id a16sm12066018pfc.37.2021.05.18.05.25.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 May 2021 05:25:03 -0700 (PDT) Date: Tue, 18 May 2021 12:24:57 +0000 From: Rudi Heitbaum To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Florian Fainelli , Vladimir Oltean , "David S. Miller" , Sasha Levin Subject: Re: [PATCH 5.12 081/363] net: bridge: propagate error code and extack from br_mc_disabled_update Message-ID: <20210518122449.GA65@ec3d6f83b95b> References: <20210517140302.508966430@linuxfoundation.org> <20210517140305.339768334@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210517140305.339768334@linuxfoundation.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 17, 2021 at 03:59:07PM +0200, Greg Kroah-Hartman wrote: > From: Florian Fainelli > > [ Upstream commit ae1ea84b33dab45c7b6c1754231ebda5959b504c ] > > Some Ethernet switches might only be able to support disabling multicast > snooping globally, which is an issue for example when several bridges > span the same physical device and request contradictory settings. > > Propagate the return value of br_mc_disabled_update() such that this > limitation is transmitted correctly to user-space. > > Signed-off-by: Florian Fainelli > Signed-off-by: Vladimir Oltean > Signed-off-by: David S. Miller > Signed-off-by: Sasha Levin > --- > net/bridge/br_multicast.c | 28 +++++++++++++++++++++------- > net/bridge/br_netlink.c | 4 +++- > net/bridge/br_private.h | 3 ++- > net/bridge/br_sysfs_br.c | 8 +------- > 4 files changed, 27 insertions(+), 16 deletions(-) This patch results in docker failing to start, and a regression between 5.12.4 and 5.12.5-rc1 A working dmesg output is like: [ 11.545255] device eth0 entered promiscuous mode [ 11.693848] process 'docker/tmp/qemu-check643160757/check' started with executable stack [ 17.233059] br-92020c7e3aea: port 1(veth17a0552) entered blocking state [ 17.233065] br-92020c7e3aea: port 1(veth17a0552) entered disabled state [ 17.233098] device veth17a0552 entered promiscuous mode [ 17.292839] docker0: port 2(veth9d227f5) entered blocking state [ 17.292848] docker0: port 2(veth9d227f5) entered disabled state [ 17.292946] device veth9d227f5 entered promiscuous mode [ 17.293070] docker0: port 2(veth9d227f5) entered blocking state [ 17.293075] docker0: port 2(veth9d227f5) entered forwarding state with this patch "device veth17a0552 entered promiscuous mode" never shows up. the docker error itself is: docker: Error response from daemon: failed to create endpoint sleepy_dijkstra on network bridge: adding interface veth8cbd8f9 to bridge docker0 failed: operation not supported. Regards Rudi