From: Hamza Mahfooz <someguy@effective-light.com>
To: linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org,
Hamza Mahfooz <someguy@effective-light.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: [PATCH] dma debug: report -EEXIST errors in add_dma_entry
Date: Tue, 18 May 2021 08:54:43 -0400 [thread overview]
Message-ID: <20210518125443.34148-1-someguy@effective-light.com> (raw)
Since, overlapping mappings are not supported by the DMA API we should
report an error if active_cacheline_insert returns -EEXIST.
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
---
kernel/dma/debug.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
index 14de1271463f..dadae6255d05 100644
--- a/kernel/dma/debug.c
+++ b/kernel/dma/debug.c
@@ -566,11 +566,9 @@ static void add_dma_entry(struct dma_debug_entry *entry)
if (rc == -ENOMEM) {
pr_err("cacheline tracking ENOMEM, dma-debug disabled\n");
global_disable = true;
+ } else if (rc == -EEXIST) {
+ pr_err("cacheline tracking EEXIST, overlapping mappings aren't supported\n");
}
-
- /* TODO: report -EEXIST errors here as overlapping mappings are
- * not supported by the DMA API
- */
}
static int dma_debug_create_entries(gfp_t gfp)
--
2.31.1
next reply other threads:[~2021-05-18 12:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 12:54 Hamza Mahfooz [this message]
2021-06-22 7:41 ` [PATCH] dma debug: report -EEXIST errors in add_dma_entry Christoph Hellwig
2021-09-09 3:33 ` DPAA2 triggers, " Jeremy Linton
2021-09-09 21:16 ` Ioana Ciornei
2021-09-10 10:23 ` Christoph Hellwig
2021-09-14 15:45 ` Ioana Ciornei
2021-09-30 13:37 ` Karsten Graul
2021-10-01 12:52 ` Gerald Schaefer
2021-10-06 13:10 ` Gerald Schaefer
2021-10-06 13:21 ` Gerald Schaefer
2021-10-06 14:23 ` Robin Murphy
2021-10-06 15:06 ` Gerald Schaefer
2021-10-07 10:59 ` Karsten Graul
2021-10-07 16:40 ` Gerald Schaefer
2021-10-11 11:47 ` Christoph Hellwig
2021-10-01 4:19 ` Christoph Hellwig
2021-10-01 9:21 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518125443.34148-1-someguy@effective-light.com \
--to=someguy@effective-light.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).