From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0411CC433B4 for ; Tue, 18 May 2021 13:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D27496105A for ; Tue, 18 May 2021 13:34:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245118AbhERNf7 (ORCPT ); Tue, 18 May 2021 09:35:59 -0400 Received: from mga05.intel.com ([192.55.52.43]:26478 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237343AbhERNf6 (ORCPT ); Tue, 18 May 2021 09:35:58 -0400 IronPort-SDR: CenqPQwkPTkCAfPHXNIaw3G5YT6P/7YLwJSdFX96zr7N8S/zd3rx5aA3UYPLl5OjjhPJqrcVMa X/6h5QLQxX1g== X-IronPort-AV: E=McAfee;i="6200,9189,9987"; a="286243878" X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="286243878" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 06:34:40 -0700 IronPort-SDR: SsrzPs4CzhROs3dv892beFg+r4USSr6aSc/wjFSqYObdE5TgMdAqvoQHzBK+g+7lJocWahocQN 38z+9YOHtDZw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="411275283" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 18 May 2021 06:34:39 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 5090812F; Tue, 18 May 2021 16:35:00 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Sudip Mukherjee , Greg Kroah-Hartman Subject: [PATCH v1 1/1] parport: Use string_upper() instead of open coded variant Date: Tue, 18 May 2021 16:34:58 +0300 Message-Id: <20210518133458.20403-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use string_upper() from string helper module instead of open coded variant. Signed-off-by: Andy Shevchenko --- drivers/parport/probe.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/parport/probe.c b/drivers/parport/probe.c index 7e6d713fa5ac..5d1b9aacb130 100644 --- a/drivers/parport/probe.c +++ b/drivers/parport/probe.c @@ -8,8 +8,8 @@ #include #include -#include #include +#include #include #include @@ -74,11 +74,7 @@ static void parse_data(struct parport *port, int device, char *str) u = sep + strlen (sep) - 1; while (u >= p && *u == ' ') *u-- = '\0'; - u = p; - while (*u) { - *u = toupper(*u); - u++; - } + string_upper(p, p); if (!strcmp(p, "MFG") || !strcmp(p, "MANUFACTURER")) { kfree(info->mfr); info->mfr = kstrdup(sep, GFP_KERNEL); @@ -90,8 +86,7 @@ static void parse_data(struct parport *port, int device, char *str) kfree(info->class_name); info->class_name = kstrdup(sep, GFP_KERNEL); - for (u = sep; *u; u++) - *u = toupper(*u); + string_upper(sep, sep); for (i = 0; classes[i].token; i++) { if (!strcmp(classes[i].token, sep)) { info->class = i; -- 2.30.2