From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFF5AC433ED for ; Tue, 18 May 2021 23:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 853996124C for ; Tue, 18 May 2021 23:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238271AbhERXVd (ORCPT ); Tue, 18 May 2021 19:21:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:43756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237815AbhERXVb (ORCPT ); Tue, 18 May 2021 19:21:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EBB6061059; Tue, 18 May 2021 23:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621380013; bh=AwH0YVAxJ9zD68qS2yu5RNzH4jRt80k+k9fn6Ttgrpg=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=LB8tvo8Ia7YYRkggSkKbiyiwcT5IzZT3u0KbNF3f48mvRZ6nTkiTHivR3AakfyI96 6iycw/ap0mYOyTzyZWLKjNdhrfwcIMC/3jRPsIbPfvIyfiHKU1OtMVgSy7rYjR95ro HS25yOVmL2wB+ytb1P/wfkHr+Gq+nN1XbQHaiU7Ka76dkje2t5uRAxYoB6qQKgTYsh aBi2ddR5ie1MoTzjmzgoc/5NGf1nLT3XeB+44sQxWp/sxh1SvUmuXBybPqyfuKwByD JwPV/4KEg3kGluKIllXgakHy94AtVKTB1JLtRKZWiGgIgQFbTw6+BhepwGvm1l57EU e/0iDDeGlw4eQ== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id B862D5C013C; Tue, 18 May 2021 16:20:12 -0700 (PDT) Date: Tue, 18 May 2021 16:20:12 -0700 From: "Paul E. McKenney" To: Marco Elver Cc: Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Greg Kroah-Hartman , Dmitry Vyukov , kasan-dev , Linux Kernel Mailing List , clang-built-linux Subject: Re: [PATCH] kcsan: fix debugfs initcall return type Message-ID: <20210518232012.GA2976391@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20210514140015.2944744-1-arnd@kernel.org> <0ad11966-b286-395e-e9ca-e278de6ef872@kernel.org> <20210514193657.GM975577@paulmck-ThinkPad-P17-Gen-1> <534d9b03-6fb2-627a-399d-36e7127e19ff@kernel.org> <20210514201808.GO975577@paulmck-ThinkPad-P17-Gen-1> <20210515005550.GQ975577@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210515005550.GQ975577@paulmck-ThinkPad-P17-Gen-1> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 05:55:50PM -0700, Paul E. McKenney wrote: > On Sat, May 15, 2021 at 01:01:31AM +0200, Marco Elver wrote: > > On Fri, May 14, 2021 at 11:16PM +0200, Arnd Bergmann wrote: > > > On Fri, May 14, 2021 at 10:18 PM Paul E. McKenney wrote: > > > > On Fri, May 14, 2021 at 01:11:05PM -0700, Nathan Chancellor wrote: > > > > > > > > You can see my response to Marco here: > > > > > > > > > > https://lore.kernel.org/r/ad7fa126-f371-5a24-1d80-27fe8f655b05@kernel.org/ > > > > > > > > > > Maybe some improved wording might look like > > > > > > > > > > clang with CONFIG_LTO_CLANG points out that an initcall function should > > > > > return an 'int' due to the changes made to the initcall macros in commit > > > > > 3578ad11f3fb ("init: lto: fix PREL32 relocations"): > > > > > > > > OK, so the naive reading was correct, thank you! > > > > > > > > > ... > > > > > > > > > > Arnd, do you have any objections? > > > > > > > > In the meantime, here is what I have. Please let me know of any needed > > > > updates. > > > > > > > > > > Looks good to me, thanks for the improvements! > > > > FWIW, this prompted me to see if I can convince the compiler to complain > > in all configs. The below is what I came up with and will send once the > > fix here has landed. Need to check a few other config+arch combinations > > (allyesconfig with gcc on x86_64 is good). > > Cool! > > If I have not sent the pull request for Arnd's fix by Wednesday, please > remind me. Except that I was slow getting Miguel Ojeda's Reviewed-by applied. I need to wait for -next to incorporate this change (hopefully by tomorrow, Pacific Time), and then test this. With luck, I will send this Thursday, Pacific Time. Thanx, Paul