From: Quan Nguyen <quan@os.amperecomputing.com> To: Corey Minyard <minyard@acm.org>, Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Brendan Higgins <brendanhiggins@google.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Wolfram Sang <wsa@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Cc: Open Source Submission <patches@amperecomputing.com>, Phong Vo <phong@os.amperecomputing.com>, "Thang Q . Nguyen" <thang@os.amperecomputing.com>, openbmc@lists.ozlabs.org Subject: [PATCH v3 5/7] i2c: aspeed: Add aspeed_set_slave_busy() Date: Wed, 19 May 2021 14:49:32 +0700 [thread overview] Message-ID: <20210519074934.20712-6-quan@os.amperecomputing.com> (raw) In-Reply-To: <20210519074934.20712-1-quan@os.amperecomputing.com> Slave i2c device on AST2500 received a lot of slave irq while it is busy processing the response. To handle this case, adds and exports aspeed_set_slave_busy() for controller to temporary stop slave irq while slave is handling the response, and re-enable them again when the response is ready. Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com> --- v3: + First introduce in v3 [Quan] drivers/i2c/busses/i2c-aspeed.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c index b2e9c8f0ddf7..9926d04831a2 100644 --- a/drivers/i2c/busses/i2c-aspeed.c +++ b/drivers/i2c/busses/i2c-aspeed.c @@ -944,6 +944,26 @@ static int aspeed_i2c_init(struct aspeed_i2c_bus *bus, return 0; } +#if IS_ENABLED(CONFIG_I2C_SLAVE) +void aspeed_set_slave_busy(struct i2c_adapter *adap, bool busy) +{ + struct aspeed_i2c_bus *bus = i2c_get_adapdata(adap); + unsigned long current_mask, flags; + + spin_lock_irqsave(&bus->lock, flags); + + current_mask = readl(bus->base + ASPEED_I2C_INTR_CTRL_REG); + if (busy) + current_mask &= ~(ASPEED_I2CD_INTR_RX_DONE | ASPEED_I2CD_INTR_SLAVE_MATCH); + else + current_mask |= ASPEED_I2CD_INTR_RX_DONE | ASPEED_I2CD_INTR_SLAVE_MATCH; + writel(current_mask, bus->base + ASPEED_I2C_INTR_CTRL_REG); + + spin_unlock_irqrestore(&bus->lock, flags); +} +EXPORT_SYMBOL_GPL(aspeed_set_slave_busy); +#endif + static int aspeed_i2c_reset(struct aspeed_i2c_bus *bus) { struct platform_device *pdev = to_platform_device(bus->dev); -- 2.28.0
next prev parent reply other threads:[~2021-05-19 7:50 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-19 7:49 [PATCH v3 0/7] Add Aspeed SSIF BMC driver Quan Nguyen 2021-05-19 7:49 ` [PATCH v3 1/7] i2c: i2c-core-smbus: Expose PEC calculate function for generic use Quan Nguyen 2021-06-25 15:02 ` Wolfram Sang 2021-05-19 7:49 ` [PATCH v3 2/7] ipmi: ssif_bmc: Add SSIF BMC driver Quan Nguyen 2021-05-19 12:30 ` Corey Minyard 2021-05-20 14:19 ` Quan Nguyen 2021-05-19 7:49 ` [PATCH v3 3/7] i2c: aspeed: Fix unhandled Tx done with NAK Quan Nguyen 2021-05-19 23:28 ` Joel Stanley 2021-05-20 11:28 ` Ryan Chen 2021-05-20 14:15 ` Quan Nguyen 2021-05-20 13:48 ` Quan Nguyen 2021-05-19 7:49 ` [PATCH v3 4/7] i2c: aspeed: Acknowledge Tx done w/wo ACK irq late Quan Nguyen 2021-05-19 23:43 ` Joel Stanley 2021-05-20 1:19 ` Guenter Roeck 2021-05-20 14:03 ` Quan Nguyen 2021-05-20 13:52 ` Quan Nguyen 2021-05-19 7:49 ` Quan Nguyen [this message] 2021-05-20 11:06 ` [PATCH v3 5/7] i2c: aspeed: Add aspeed_set_slave_busy() Ryan Chen 2021-05-20 14:10 ` Quan Nguyen 2021-05-21 6:09 ` Ryan Chen 2021-05-28 1:00 ` Quan Nguyen 2021-05-24 10:06 ` Ryan Chen 2021-05-24 10:20 ` Quan Nguyen 2021-05-24 10:36 ` Ryan Chen 2021-05-24 10:48 ` Quan Nguyen 2021-05-25 10:30 ` Ryan Chen 2021-05-28 0:53 ` Quan Nguyen 2021-05-28 2:57 ` Ryan Chen 2021-06-07 14:57 ` Graeme Gregory 2021-05-19 7:49 ` [PATCH v3 6/7] ipmi: ssif_bmc: Add Aspeed SSIF BMC driver Quan Nguyen 2021-05-19 7:49 ` [PATCH v3 7/7] bindings: ipmi: Add binding for " Quan Nguyen 2021-05-19 15:29 ` Rob Herring 2021-05-20 14:24 ` Quan Nguyen 2021-05-19 12:34 ` [PATCH v3 0/7] Add " Corey Minyard 2021-05-20 14:23 ` Quan Nguyen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210519074934.20712-6-quan@os.amperecomputing.com \ --to=quan@os.amperecomputing.com \ --cc=andrew@aj.id.au \ --cc=benh@kernel.crashing.org \ --cc=brendanhiggins@google.com \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=minyard@acm.org \ --cc=openbmc@lists.ozlabs.org \ --cc=openipmi-developer@lists.sourceforge.net \ --cc=p.zabel@pengutronix.de \ --cc=patches@amperecomputing.com \ --cc=phong@os.amperecomputing.com \ --cc=robh+dt@kernel.org \ --cc=thang@os.amperecomputing.com \ --cc=wsa@kernel.org \ --subject='Re: [PATCH v3 5/7] i2c: aspeed: Add aspeed_set_slave_busy()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).