From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Meng.Li@windriver.com
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
pmeerw@pmeerw.net, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] driver: adc: ltc2497: return directly after reading the adc conversion value
Date: Wed, 19 May 2021 11:21:04 +0200 [thread overview]
Message-ID: <20210519092104.pntanimcjg6s6fca@pengutronix.de> (raw)
In-Reply-To: <20210512045725.23390-1-Meng.Li@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 2065 bytes --]
On Wed, May 12, 2021 at 12:57:25PM +0800, Meng.Li@windriver.com wrote:
> From: Meng Li <Meng.Li@windriver.com>
>
> When read adc conversion value with below command:
> cat /sys/.../iio:device0/in_voltage0-voltage1_raw
> There is an error reported as below:
> ltc2497 0-0014: i2c transfer failed: -EREMOTEIO
> This i2c transfer issue is introduced by commit 69548b7c2c4f ("iio:
> adc: ltc2497: split protocol independent part in a separate module").
> When extract the common code into ltc2497-core.c, it change the
> code logic of function ltc2497core_read(). With wrong reading
> sequence, the action of enable adc channel is sent to chip again
> during adc channel is in conversion status. In this way, there is
> no ack from chip, and then cause i2c transfer failed.
> In order to keep the code logic is the same with original ideal,
> it is need to return direct after reading the adc conversion value.
>
> Fixes: 69548b7c2c4f ("iio: adc: ltc2497: split protocol independent part in a separate module ")
> Cc: stable@vger.kernel.org
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
> drivers/iio/adc/ltc2497.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/adc/ltc2497.c b/drivers/iio/adc/ltc2497.c
> index 1adddf5a88a9..fd5a66860a47 100644
> --- a/drivers/iio/adc/ltc2497.c
> +++ b/drivers/iio/adc/ltc2497.c
> @@ -41,6 +41,8 @@ static int ltc2497_result_and_measure(struct ltc2497core_driverdata *ddata,
> }
>
> *val = (be32_to_cpu(st->buf) >> 14) - (1 << 17);
> +
> + return ret;
This looks wrong for me. The idea of the function
ltc2497_result_and_measure is that it reads the result and starts a new
measurement. I guess the problem is that ltc2497_result_and_measure is
called to early, not that it does too much.
But note I don't have such a system handy to actually debug this any
more.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-19 9:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 4:57 [PATCH] driver: adc: ltc2497: return directly after reading the adc conversion value Meng.Li
2021-05-18 17:46 ` Jonathan Cameron
2021-05-19 9:21 ` Uwe Kleine-König [this message]
2021-05-21 17:01 ` Jonathan Cameron
2021-05-24 2:49 ` Li, Meng
2021-05-25 8:19 ` Jonathan Cameron
2021-05-24 2:53 ` Li, Meng
2021-05-25 8:22 ` Felix Knopf
2021-05-25 10:36 ` Li, Meng
2021-06-01 9:28 Meng.Li
2021-06-03 16:20 ` Jonathan Cameron
2021-06-04 2:16 ` Li, Meng
2021-06-04 6:13 ` Uwe Kleine-König
2021-06-04 6:43 ` Li, Meng
2021-06-04 8:20 ` Jonathan Cameron
2021-06-04 8:53 ` Uwe Kleine-König
2021-06-04 9:04 ` Li, Meng
2021-06-04 9:32 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519092104.pntanimcjg6s6fca@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Meng.Li@windriver.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).