From: Mark Brown <broonie@kernel.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Check ramp_delay_table for regulator_set_ramp_delay_regmap
Date: Wed, 19 May 2021 14:16:26 +0100 [thread overview]
Message-ID: <20210519131626.GE4224@sirena.org.uk> (raw)
In-Reply-To: <20210519075024.1644990-1-axel.lin@ingics.com>
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
On Wed, May 19, 2021 at 03:50:24PM +0800, Axel Lin wrote:
> + if (!rdev->desc->n_ramp_values || !rdev->desc->ramp_delay_table) {
> + WARN_ON(!rdev->desc->n_ramp_values || !rdev->desc->ramp_delay_table);
You can write "if (WARN_ON(..." there and it'll DTRT, though I'm never
sure it's great for readability.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-19 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 7:50 [PATCH] regulator: Check ramp_delay_table for regulator_set_ramp_delay_regmap Axel Lin
2021-05-19 13:16 ` Mark Brown [this message]
2021-05-19 16:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519131626.GE4224@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).