From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1704C433ED for ; Thu, 20 May 2021 03:16:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A68A7610CC for ; Thu, 20 May 2021 03:16:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbhETDRi (ORCPT ); Wed, 19 May 2021 23:17:38 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:10519 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhETDRh (ORCPT ); Wed, 19 May 2021 23:17:37 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 14K33WIl039595; Thu, 20 May 2021 11:03:32 +0800 (GMT-8) (envelope-from jamin_lin@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 20 May 2021 11:16:09 +0800 Date: Thu, 20 May 2021 11:16:08 +0800 From: Jamin Lin To: Rob Herring CC: Brendan Higgins , Steven Lee , Rayn Chen , "Benjamin Herrenschmidt" , Andrew Jeffery , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list:I2C SUBSYSTEM HOST DRIVERS" , "ChiaWei Wang" , Joel Stanley , Ryan Chen , Rob Herring , "moderated list:ARM/ASPEED I2C DRIVER" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list" , Troy Lee , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH 3/3] dt-bindings: aspeed-i2c: Convert txt to yaml format Message-ID: <20210520031608.GA3601@aspeedtech.com> References: <20210519080436.18975-1-jamin_lin@aspeedtech.com> <20210519080436.18975-4-jamin_lin@aspeedtech.com> <1621438164.132520.3134233.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1621438164.132520.3134233.nullmailer@robh.at.kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 14K33WIl039595 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 05/19/2021 15:29, Rob Herring wrote: > On Wed, 19 May 2021 16:04:29 +0800, Jamin Lin wrote: > > Add global-reg node for AST2600. Document the properties for > > "aspeed,ast2600-i2c-global" compatible node. > > > > Signed-off-by: Jamin Lin > > --- > > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 89 +++++++++++++++++++ > > .../devicetree/bindings/i2c/i2c-aspeed.txt | 49 ---------- > > 2 files changed, 89 insertions(+), 49 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/i2c/aspeed,i2c.example.dt.yaml:0:0: /example-0/i2c-global-regs@0: failed to match any schema with compatible: ['aspeed,ast2600-i2c-global', 'syscon'] > > See https://patchwork.ozlabs.org/patch/1480769 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > Thanks for your review. yes, I did not add "DT_CHECKER_FLAGS" to check my patch. I will re-sent this patch. Thanks