From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C703C43460 for ; Thu, 20 May 2021 08:40:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E8AC610CB for ; Thu, 20 May 2021 08:40:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231294AbhETIl6 (ORCPT ); Thu, 20 May 2021 04:41:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:40606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231208AbhETIl5 (ORCPT ); Thu, 20 May 2021 04:41:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7023860E09; Thu, 20 May 2021 08:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621500036; bh=9lMFE/wOwBjZrwNwRhEMmXbUPibX8C5KbGbXR7vX1Ik=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JDVbF+LV3KbT3feNmZ7ctQnbsm8METdwil3rB9cebi2S08lFMi88QvAi7DZKh9l8c Vp40W+3XgSse8WpKibMC6iA2Yg91S/GUGJlvA4Z4VFp2Vb8JAqRkH8BgavRjd9lpdJ XFQNWaYdqeKtf1rKoeITxKJw2RaWZKdVAmqZclbtUx04K8OvZ13WvDWJW9kUFPwWMm +iL4XPqNf8Tycw5XeSgRHZdG12yv1Dr+AWKuYakSq69IDB3L2qMtahkBLcExss+2Hm /6vQIg67Ou81VCyhkmXhAeUOuPiU1x6Zu1DobmGjJM2bB1Jk6Zo9s7i+8kAr6r/RtK j6495jlX4l1Iw== Date: Thu, 20 May 2021 16:40:24 +0800 From: Gao Xiang To: Dan Carpenter , Wei Yongjun Cc: Pratik Shinde , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Hulk Robot , Gao Xiang , linux-erofs@lists.ozlabs.org Subject: Re: [PATCH -next] erofs: fix error return code in erofs_read_superblock() Message-ID: <20210520084023.GA5720@hsiangkao-HP-ZHAN-66-Pro-G1> References: <20210519141657.3062715-1-weiyongjun1@huawei.com> <20210520053226.GB1955@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210520053226.GB1955@kadam> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yongjun and Dan, On Thu, May 20, 2021 at 08:32:26AM +0300, Dan Carpenter wrote: > On Wed, May 19, 2021 at 02:16:57PM +0000, Wei Yongjun wrote: > > 'ret' will be overwritten to 0 if erofs_sb_has_sb_chksum() return true, > > thus 0 will return in some error handling cases. Fix to return negative > > error code -EINVAL instead of 0. > > > > Reported-by: Hulk Robot > > Signed-off-by: Wei Yongjun > > You need to add Fixes tags to bug fix patches and you need to ensure > that the authors of the Fixes commit are CC'd so they can review your > fix. get_maintainer.pl will add the author automatically, but normally > I like to put them in the To header to make sure they see it. > > Fixes: b858a4844cfb ("erofs: support superblock checksum") The commit and the tag look good to me (sorry for a bit delay on this), Fixes: b858a4844cfb ("erofs: support superblock checksum") Cc: stable # 5.5+ Reviewed-by: Gao Xiang (will apply to dev-test for a while and then to -next.) Thanks, Gao Xiang