* [PATCH 0/7] Rid W=1 warnings from MFD
@ 2021-05-20 12:08 Lee Jones
2021-05-20 12:08 ` [PATCH 1/7] mfd: wm831x-core: Fix incorrect function name wm831x_reg_unlock() Lee Jones
` (6 more replies)
0 siblings, 7 replies; 9+ messages in thread
From: Lee Jones @ 2021-05-20 12:08 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Andrey Smirnov, Kai Svahn, Keshava Munegowda,
Kumar Sanghvi, Linus Walleij, linux-arm-kernel, linux-omap,
Mark Brown, Mattias Nilsson, patches, Roger Quadros, Sundar Iyer,
syed khasim, Tony Lindgren
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (7):
mfd: wm831x-core: Fix incorrect function name wm831x_reg_unlock()
mfd: twl-core: Fix incorrect function name twl_regcache_bypass()
mfd: db8500-prcmu: Fix multiple incorrectly documented function names
mfd: omap-usb-host: File headers are not good candidates for
kernel-doc
mfd: omap-usb-tll: File headers are not good candidates for kernel-doc
mfd: si476x-cmd: Fix a bunch of incorrectly documented function names
mfd: si476x-i2c: Fix incorrectly documented function names
drivers/mfd/db8500-prcmu.c | 6 +++---
drivers/mfd/omap-usb-host.c | 2 +-
drivers/mfd/omap-usb-tll.c | 2 +-
drivers/mfd/si476x-cmd.c | 24 ++++++++++++------------
drivers/mfd/si476x-i2c.c | 10 +++++-----
drivers/mfd/twl-core.c | 2 +-
drivers/mfd/wm831x-core.c | 2 +-
7 files changed, 24 insertions(+), 24 deletions(-)
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Kai Svahn <kai.svahn@nokia.com>
Cc: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: Kumar Sanghvi <kumar.sanghvi@stericsson.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-omap@vger.kernel.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Mattias Nilsson <mattias.i.nilsson@stericsson.com>
Cc: patches@opensource.cirrus.com
Cc: Roger Quadros <rogerq@ti.com>
Cc: Sundar Iyer <sundar.iyer@stericsson.com>
Cc: syed khasim <x0khasim@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
--
2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/7] mfd: wm831x-core: Fix incorrect function name wm831x_reg_unlock()
2021-05-20 12:08 [PATCH 0/7] Rid W=1 warnings from MFD Lee Jones
@ 2021-05-20 12:08 ` Lee Jones
2021-05-21 9:02 ` Charles Keepax
2021-05-20 12:08 ` [PATCH 2/7] mfd: twl-core: Fix incorrect function name twl_regcache_bypass() Lee Jones
` (5 subsequent siblings)
6 siblings, 1 reply; 9+ messages in thread
From: Lee Jones @ 2021-05-20 12:08 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Mark Brown, patches
Fixes the following W=1 kernel build warning(s):
drivers/mfd/wm831x-core.c:121: warning: expecting prototype for wm831x_reg_unlock(). Prototype was for wm831x_reg_lock() instead
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: patches@opensource.cirrus.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/wm831x-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/wm831x-core.c b/drivers/mfd/wm831x-core.c
index bcef08f58fb3f..c31809b17547e 100644
--- a/drivers/mfd/wm831x-core.c
+++ b/drivers/mfd/wm831x-core.c
@@ -109,7 +109,7 @@ static int wm831x_reg_locked(struct wm831x *wm831x, unsigned short reg)
}
/**
- * wm831x_reg_unlock: Unlock user keyed registers
+ * wm831x_reg_lock: Unlock user keyed registers
*
* The WM831x has a user key preventing writes to particularly
* critical registers. This function locks those registers,
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/7] mfd: twl-core: Fix incorrect function name twl_regcache_bypass()
2021-05-20 12:08 [PATCH 0/7] Rid W=1 warnings from MFD Lee Jones
2021-05-20 12:08 ` [PATCH 1/7] mfd: wm831x-core: Fix incorrect function name wm831x_reg_unlock() Lee Jones
@ 2021-05-20 12:08 ` Lee Jones
2021-05-20 12:08 ` [PATCH 3/7] mfd: db8500-prcmu: Fix multiple incorrectly documented function names Lee Jones
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2021-05-20 12:08 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Tony Lindgren, Kai Svahn, syed khasim, linux-omap
Fixes the following W=1 kernel build warning(s):
drivers/mfd/twl-core.c:496: warning: expecting prototype for twl_regcache_bypass(). Prototype was for twl_set_regcache_bypass() instead
Cc: Tony Lindgren <tony@atomide.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Kai Svahn <kai.svahn@nokia.com>
Cc: syed khasim <x0khasim@ti.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/twl-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 20cf8cfe4f3b5..289b556dede28 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -485,7 +485,7 @@ int twl_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
EXPORT_SYMBOL(twl_i2c_read);
/**
- * twl_regcache_bypass - Configure the regcache bypass for the regmap associated
+ * twl_set_regcache_bypass - Configure the regcache bypass for the regmap associated
* with the module
* @mod_no: module number
* @enable: Regcache bypass state
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/7] mfd: db8500-prcmu: Fix multiple incorrectly documented function names
2021-05-20 12:08 [PATCH 0/7] Rid W=1 warnings from MFD Lee Jones
2021-05-20 12:08 ` [PATCH 1/7] mfd: wm831x-core: Fix incorrect function name wm831x_reg_unlock() Lee Jones
2021-05-20 12:08 ` [PATCH 2/7] mfd: twl-core: Fix incorrect function name twl_regcache_bypass() Lee Jones
@ 2021-05-20 12:08 ` Lee Jones
2021-05-20 12:08 ` [PATCH 4/7] mfd: omap-usb-host: File headers are not good candidates for kernel-doc Lee Jones
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2021-05-20 12:08 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Linus Walleij, Kumar Sanghvi, Sundar Iyer,
Mattias Nilsson, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/mfd/db8500-prcmu.c:624: warning: expecting prototype for prcmu_get_current_mode(). Prototype was for prcmu_get_xp70_current_state() instead
drivers/mfd/db8500-prcmu.c:908: warning: expecting prototype for db8500_set_ape_opp(). Prototype was for db8500_prcmu_set_ape_opp() instead
drivers/mfd/db8500-prcmu.c:2303: warning: expecting prototype for db8500_prcmu_reset_modem(). Prototype was for db8500_prcmu_modem_reset() instead
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Kumar Sanghvi <kumar.sanghvi@stericsson.com>
Cc: Sundar Iyer <sundar.iyer@stericsson.com>
Cc: Mattias Nilsson <mattias.i.nilsson@stericsson.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/db8500-prcmu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 167faac9b75bf..3bde7fda755f1 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -616,7 +616,7 @@ enum romcode_read prcmu_get_rc_p2a(void)
}
/**
- * prcmu_get_current_mode - Return the current XP70 power mode
+ * prcmu_get_xp70_current_state - Return the current XP70 power mode
* Returns: Returns the current AP(ARM) power mode: init,
* apBoot, apExecute, apDeepSleep, apSleep, apIdle, apReset
*/
@@ -898,7 +898,7 @@ static void request_even_slower_clocks(bool enable)
}
/**
- * db8500_set_ape_opp - set the appropriate APE OPP
+ * db8500_prcmu_set_ape_opp - set the appropriate APE OPP
* @opp: The new APE operating point to which transition is to be made
* Returns: 0 on success, non-zero on failure
*
@@ -2297,7 +2297,7 @@ u16 db8500_prcmu_get_reset_code(void)
}
/**
- * db8500_prcmu_reset_modem - ask the PRCMU to reset modem
+ * db8500_prcmu_modem_reset - ask the PRCMU to reset modem
*/
void db8500_prcmu_modem_reset(void)
{
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/7] mfd: omap-usb-host: File headers are not good candidates for kernel-doc
2021-05-20 12:08 [PATCH 0/7] Rid W=1 warnings from MFD Lee Jones
` (2 preceding siblings ...)
2021-05-20 12:08 ` [PATCH 3/7] mfd: db8500-prcmu: Fix multiple incorrectly documented function names Lee Jones
@ 2021-05-20 12:08 ` Lee Jones
2021-05-20 12:08 ` [PATCH 5/7] mfd: omap-usb-tll: " Lee Jones
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2021-05-20 12:08 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Tony Lindgren, Keshava Munegowda, Roger Quadros,
linux-omap
Fixes the following W=1 kernel build warning(s):
drivers/mfd/omap-usb-host.c:26: warning: expecting prototype for omap(). Prototype was for USBHS_DRIVER_NAME() instead
Cc: Tony Lindgren <tony@atomide.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: Roger Quadros <rogerq@ti.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/omap-usb-host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 2a3a240b4619a..787d2ae863752 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
* omap-usb-host.c - The USBHS core driver for OMAP EHCI & OHCI
*
* Copyright (C) 2011-2013 Texas Instruments Incorporated - https://www.ti.com
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 5/7] mfd: omap-usb-tll: File headers are not good candidates for kernel-doc
2021-05-20 12:08 [PATCH 0/7] Rid W=1 warnings from MFD Lee Jones
` (3 preceding siblings ...)
2021-05-20 12:08 ` [PATCH 4/7] mfd: omap-usb-host: File headers are not good candidates for kernel-doc Lee Jones
@ 2021-05-20 12:08 ` Lee Jones
2021-05-20 12:08 ` [PATCH 6/7] mfd: si476x-cmd: Fix a bunch of incorrectly documented function names Lee Jones
2021-05-20 12:08 ` [PATCH 7/7] mfd: si476x-i2c: Fix " Lee Jones
6 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2021-05-20 12:08 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Tony Lindgren, Keshava Munegowda, Roger Quadros,
linux-omap
Fixes the following W=1 kernel build warning(s):
drivers/mfd/omap-usb-tll.c:24: warning: expecting prototype for omap(). Prototype was for USBTLL_DRIVER_NAME() instead
Cc: Tony Lindgren <tony@atomide.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: Roger Quadros <rogerq@ti.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/omap-usb-tll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index 16fad79c73f1f..080d7970a3774 100644
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
* omap-usb-tll.c - The USB TLL driver for OMAP EHCI & OHCI
*
* Copyright (C) 2012-2013 Texas Instruments Incorporated - https://www.ti.com
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 6/7] mfd: si476x-cmd: Fix a bunch of incorrectly documented function names
2021-05-20 12:08 [PATCH 0/7] Rid W=1 warnings from MFD Lee Jones
` (4 preceding siblings ...)
2021-05-20 12:08 ` [PATCH 5/7] mfd: omap-usb-tll: " Lee Jones
@ 2021-05-20 12:08 ` Lee Jones
2021-05-20 12:08 ` [PATCH 7/7] mfd: si476x-i2c: Fix " Lee Jones
6 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2021-05-20 12:08 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Andrey Smirnov
Fixes the following W=1 kernel build warning(s):
drivers/mfd/si476x-cmd.c:406: warning: expecting prototype for si476x_cmd_func_info(). Prototype was for si476x_core_cmd_func_info() instead
drivers/mfd/si476x-cmd.c:437: warning: expecting prototype for si476x_cmd_set_property(). Prototype was for si476x_core_cmd_set_property() instead
drivers/mfd/si476x-cmd.c:463: warning: expecting prototype for si476x_cmd_get_property(). Prototype was for si476x_core_cmd_get_property() instead
drivers/mfd/si476x-cmd.c:525: warning: expecting prototype for si476x_cmd_dig_audio_pin_cfg(). Prototype was for si476x_core_cmd_dig_audio_pin_cfg() instead
drivers/mfd/si476x-cmd.c:574: warning: expecting prototype for si476x_cmd_zif_pin_cfg(). Prototype was for si476x_core_cmd_zif_pin_cfg() instead
drivers/mfd/si476x-cmd.c:631: warning: expecting prototype for si476x_cmd_ic_link_gpo_ctl_pin_cfg(). Prototype was for si476x_core_cmd_ic_link_gpo_ctl_pin_cfg() instead
drivers/mfd/si476x-cmd.c:662: warning: expecting prototype for si476x_cmd_ana_audio_pin_cfg(). Prototype was for si476x_core_cmd_ana_audio_pin_cfg() instead
drivers/mfd/si476x-cmd.c:697: warning: expecting prototype for si476x_cmd_intb_pin_cfg(). Prototype was for si476x_core_cmd_intb_pin_cfg_a10() instead
drivers/mfd/si476x-cmd.c:742: warning: expecting prototype for si476x_cmd_am_rsq_status(). Prototype was for si476x_core_cmd_am_rsq_status() instead
drivers/mfd/si476x-cmd.c:874: warning: expecting prototype for si476x_cmd_fm_seek_start(). Prototype was for si476x_core_cmd_fm_seek_start() instead
drivers/mfd/si476x-cmd.c:905: warning: expecting prototype for si476x_cmd_fm_rds_status(). Prototype was for si476x_core_cmd_fm_rds_status() instead
drivers/mfd/si476x-cmd.c:1050: warning: expecting prototype for si476x_cmd_am_seek_start(). Prototype was for si476x_core_cmd_am_seek_start() instead
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/si476x-cmd.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/mfd/si476x-cmd.c b/drivers/mfd/si476x-cmd.c
index d15b3e7833692..0e4b89a967ed6 100644
--- a/drivers/mfd/si476x-cmd.c
+++ b/drivers/mfd/si476x-cmd.c
@@ -390,7 +390,7 @@ static int si476x_cmd_tune_seek_freq(struct si476x_core *core,
}
/**
- * si476x_cmd_func_info() - send 'FUNC_INFO' command to the device
+ * si476x_core_cmd_func_info() - send 'FUNC_INFO' command to the device
* @core: device to send the command to
* @info: struct si476x_func_info to fill all the information
* returned by the command
@@ -424,7 +424,7 @@ int si476x_core_cmd_func_info(struct si476x_core *core,
EXPORT_SYMBOL_GPL(si476x_core_cmd_func_info);
/**
- * si476x_cmd_set_property() - send 'SET_PROPERTY' command to the device
+ * si476x_core_cmd_set_property() - send 'SET_PROPERTY' command to the device
* @core: device to send the command to
* @property: property address
* @value: property value
@@ -452,7 +452,7 @@ int si476x_core_cmd_set_property(struct si476x_core *core,
EXPORT_SYMBOL_GPL(si476x_core_cmd_set_property);
/**
- * si476x_cmd_get_property() - send 'GET_PROPERTY' command to the device
+ * si476x_core_cmd_get_property() - send 'GET_PROPERTY' command to the device
* @core: device to send the command to
* @property: property address
*
@@ -481,7 +481,7 @@ int si476x_core_cmd_get_property(struct si476x_core *core, u16 property)
EXPORT_SYMBOL_GPL(si476x_core_cmd_get_property);
/**
- * si476x_cmd_dig_audio_pin_cfg() - send 'DIG_AUDIO_PIN_CFG' command to
+ * si476x_core_cmd_dig_audio_pin_cfg() - send 'DIG_AUDIO_PIN_CFG' command to
* the device
* @core: device to send the command to
* @dclk: DCLK pin function configuration:
@@ -539,7 +539,7 @@ int si476x_core_cmd_dig_audio_pin_cfg(struct si476x_core *core,
EXPORT_SYMBOL_GPL(si476x_core_cmd_dig_audio_pin_cfg);
/**
- * si476x_cmd_zif_pin_cfg - send 'ZIF_PIN_CFG_COMMAND'
+ * si476x_core_cmd_zif_pin_cfg - send 'ZIF_PIN_CFG_COMMAND'
* @core: - device to send the command to
* @iqclk: - IQCL pin function configuration:
* SI476X_IQCLK_NOOP - do not modify the behaviour
@@ -588,7 +588,7 @@ int si476x_core_cmd_zif_pin_cfg(struct si476x_core *core,
EXPORT_SYMBOL_GPL(si476x_core_cmd_zif_pin_cfg);
/**
- * si476x_cmd_ic_link_gpo_ctl_pin_cfg - send
+ * si476x_core_cmd_ic_link_gpo_ctl_pin_cfg - send
* 'IC_LINK_GPIO_CTL_PIN_CFG' comand to the device
* @core: - device to send the command to
* @icin: - ICIN pin function configuration:
@@ -645,7 +645,7 @@ int si476x_core_cmd_ic_link_gpo_ctl_pin_cfg(struct si476x_core *core,
EXPORT_SYMBOL_GPL(si476x_core_cmd_ic_link_gpo_ctl_pin_cfg);
/**
- * si476x_cmd_ana_audio_pin_cfg - send 'ANA_AUDIO_PIN_CFG' to the
+ * si476x_core_cmd_ana_audio_pin_cfg - send 'ANA_AUDIO_PIN_CFG' to the
* device
* @core: - device to send the command to
* @lrout: - LROUT pin function configuration:
@@ -674,7 +674,7 @@ EXPORT_SYMBOL_GPL(si476x_core_cmd_ana_audio_pin_cfg);
/**
- * si476x_cmd_intb_pin_cfg - send 'INTB_PIN_CFG' command to the device
+ * si476x_core_cmd_intb_pin_cfg_a10 - send 'INTB_PIN_CFG' command to the device
* @core: - device to send the command to
* @intb: - INTB pin function configuration:
* SI476X_INTB_NOOP - do not modify the behaviour
@@ -726,7 +726,7 @@ static int si476x_core_cmd_intb_pin_cfg_a20(struct si476x_core *core,
/**
- * si476x_cmd_am_rsq_status - send 'AM_RSQ_STATUS' command to the
+ * si476x_core_cmd_am_rsq_status - send 'AM_RSQ_STATUS' command to the
* device
* @core: - device to send the command to
* @rsqargs: - pointer to a structure containing a group of sub-args
@@ -856,7 +856,7 @@ EXPORT_SYMBOL_GPL(si476x_core_cmd_am_acf_status);
/**
- * si476x_cmd_fm_seek_start - send 'FM_SEEK_START' command to the
+ * si476x_core_cmd_fm_seek_start - send 'FM_SEEK_START' command to the
* device
* @core: - device to send the command to
* @seekup: - if set the direction of the search is 'up'
@@ -884,7 +884,7 @@ int si476x_core_cmd_fm_seek_start(struct si476x_core *core,
EXPORT_SYMBOL_GPL(si476x_core_cmd_fm_seek_start);
/**
- * si476x_cmd_fm_rds_status - send 'FM_RDS_STATUS' command to the
+ * si476x_core_cmd_fm_rds_status - send 'FM_RDS_STATUS' command to the
* device
* @core: - device to send the command to
* @status_only: - if set the data is not removed from RDSFIFO,
@@ -1032,7 +1032,7 @@ EXPORT_SYMBOL_GPL(si476x_core_cmd_fm_phase_div_status);
/**
- * si476x_cmd_am_seek_start - send 'FM_SEEK_START' command to the
+ * si476x_core_cmd_am_seek_start - send 'FM_SEEK_START' command to the
* device
* @core: - device to send the command to
* @seekup: - if set the direction of the search is 'up'
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 7/7] mfd: si476x-i2c: Fix incorrectly documented function names
2021-05-20 12:08 [PATCH 0/7] Rid W=1 warnings from MFD Lee Jones
` (5 preceding siblings ...)
2021-05-20 12:08 ` [PATCH 6/7] mfd: si476x-cmd: Fix a bunch of incorrectly documented function names Lee Jones
@ 2021-05-20 12:08 ` Lee Jones
6 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2021-05-20 12:08 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Andrey Smirnov
Fixes the following W=1 kernel build warning(s):
drivers/mfd/si476x-i2c.c:360: warning: expecting prototype for si476x_drain_rds_fifo(). Prototype was for si476x_core_drain_rds_fifo() instead
drivers/mfd/si476x-i2c.c:467: warning: expecting prototype for si476x_get_status(). Prototype was for si476x_core_get_status() instead
drivers/mfd/si476x-i2c.c:484: warning: expecting prototype for si476x_get_and_signal_status(). Prototype was for si476x_core_get_and_signal_status() instead
drivers/mfd/si476x-i2c.c:555: warning: expecting prototype for si476x_firmware_version_to_revision(). Prototype was for si476x_core_fwver_to_revision() instead
drivers/mfd/si476x-i2c.c:619: warning: expecting prototype for si476x_get_revision_info(). Prototype was for si476x_core_get_revision_info() instead
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/si476x-i2c.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/si476x-i2c.c b/drivers/mfd/si476x-i2c.c
index c1d7b845244ed..a2635c2d9d1a9 100644
--- a/drivers/mfd/si476x-i2c.c
+++ b/drivers/mfd/si476x-i2c.c
@@ -350,7 +350,7 @@ static inline void si476x_core_start_rds_drainer_once(struct si476x_core *core)
mutex_unlock(&core->rds_drainer_status_lock);
}
/**
- * si476x_drain_rds_fifo() - RDS buffer drainer.
+ * si476x_core_drain_rds_fifo() - RDS buffer drainer.
* @work: struct work_struct being ppassed to the function by the
* kernel.
*
@@ -454,7 +454,7 @@ int si476x_core_i2c_xfer(struct si476x_core *core,
EXPORT_SYMBOL_GPL(si476x_core_i2c_xfer);
/**
- * si476x_get_status()
+ * si476x_core_get_status()
* @core: Core device structure
*
* Get the status byte of the core device by berforming one byte I2C
@@ -473,7 +473,7 @@ static int si476x_core_get_status(struct si476x_core *core)
}
/**
- * si476x_get_and_signal_status() - IRQ dispatcher
+ * si476x_core_get_and_signal_status() - IRQ dispatcher
* @core: Core device structure
*
* Dispatch the arrived interrupt request based on the value of the
@@ -532,7 +532,7 @@ static irqreturn_t si476x_core_interrupt(int irq, void *dev)
}
/**
- * si476x_firmware_version_to_revision()
+ * si476x_core_fwver_to_revision()
* @core: Core device structure
* @func: Selects the boot function of the device:
* *_BOOTLOADER - Boot loader
@@ -603,7 +603,7 @@ static int si476x_core_fwver_to_revision(struct si476x_core *core,
}
/**
- * si476x_get_revision_info()
+ * si476x_core_get_revision_info()
* @core: Core device structure
*
* Get the firmware version number of the device. It is done in
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/7] mfd: wm831x-core: Fix incorrect function name wm831x_reg_unlock()
2021-05-20 12:08 ` [PATCH 1/7] mfd: wm831x-core: Fix incorrect function name wm831x_reg_unlock() Lee Jones
@ 2021-05-21 9:02 ` Charles Keepax
0 siblings, 0 replies; 9+ messages in thread
From: Charles Keepax @ 2021-05-21 9:02 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Mark Brown, patches
On Thu, May 20, 2021 at 01:08:14PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/mfd/wm831x-core.c:121: warning: expecting prototype for wm831x_reg_unlock(). Prototype was for wm831x_reg_lock() instead
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: patches@opensource.cirrus.com
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-05-21 9:02 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20 12:08 [PATCH 0/7] Rid W=1 warnings from MFD Lee Jones
2021-05-20 12:08 ` [PATCH 1/7] mfd: wm831x-core: Fix incorrect function name wm831x_reg_unlock() Lee Jones
2021-05-21 9:02 ` Charles Keepax
2021-05-20 12:08 ` [PATCH 2/7] mfd: twl-core: Fix incorrect function name twl_regcache_bypass() Lee Jones
2021-05-20 12:08 ` [PATCH 3/7] mfd: db8500-prcmu: Fix multiple incorrectly documented function names Lee Jones
2021-05-20 12:08 ` [PATCH 4/7] mfd: omap-usb-host: File headers are not good candidates for kernel-doc Lee Jones
2021-05-20 12:08 ` [PATCH 5/7] mfd: omap-usb-tll: " Lee Jones
2021-05-20 12:08 ` [PATCH 6/7] mfd: si476x-cmd: Fix a bunch of incorrectly documented function names Lee Jones
2021-05-20 12:08 ` [PATCH 7/7] mfd: si476x-i2c: Fix " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).