From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FA52C433B4 for ; Fri, 21 May 2021 07:23:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E26361261 for ; Fri, 21 May 2021 07:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234137AbhEUHY1 (ORCPT ); Fri, 21 May 2021 03:24:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233966AbhEUHYQ (ORCPT ); Fri, 21 May 2021 03:24:16 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A9E2C0613CE for ; Fri, 21 May 2021 00:22:41 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id b7so9941239wmh.5 for ; Fri, 21 May 2021 00:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Ue4q25tfYI5RxLcBXPlMjiSrTwgCV0DfcVN25afL2bA=; b=zxBkF2RpmykF6ze5xWEoQ0Sr0EVVAWgufL4N4uYCEfvvr/9dBYRwNyhiILH7xolYIM mUMpEc0xXBJpplnd2Ws45Umks7zwOxUWKpLSks7U3bsdswos3yo/TMqCb97EECv4oO9i nPR3MbzV+M8Ol9Hmhi9U7j556tKkgEURhOKEJ/ZmzIh4muKbO6krDSxmt3Mv2RYCjfFw SNhb3NzpB5FQ50Ylct/Z3K/asq2FOTFjZf9FGqtQMB038gZT8Vu7p5RSiGdzGms2OD8X yPYCJ7kZe/aC4GAdyvCUeySQ3fymFp3DS+oe58blNwY5pF5JgI3E7v419huXJyQo0bbH XGvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Ue4q25tfYI5RxLcBXPlMjiSrTwgCV0DfcVN25afL2bA=; b=ssFH7Sxo3wFk+OA2pMFEiKqkzAjwCW7HkZHAU2eQ/HT5qD4NXMm8/QJU2iHYPSPmvf uiLjV4lj/SoAp248saTqeEljfG2zH/pmJywqYZUBffm1eRHrrtPVN98QuurAzXvbkUu3 9sRKpvOUns6XMu8nu7IVrTzSK1+g9b/WtU+m2sQ+RP4Hljj6B/cZnq3oHUmmNSvNAs2U CZ52HM7FUK68CSFHXmLdq+0WBYt5Cmu2/7oqKKm2mpChlL67v5UnqMykMdLJ/TP3A1CN cd4aMM4SzNljIGZVbqPzOjMVSSWSJi36r+u96fK7N3pj0zleTD1998DjYXVuVFIyw/+W pqog== X-Gm-Message-State: AOAM532HIn7amQ0QGvPCkNX2ea7m3lC3XpBFatUfqirw0k0eipr/n/5w 6H8vJxv2ltjZb3+Jl2y+0aAEJQ== X-Google-Smtp-Source: ABdhPJzAs4JWDKxcLcuodJXaj7alnXNl7eWaJK+ZI+9Sb3ggP4ft8Mue6yj3TwDmFJ/1VFJt4AdOjA== X-Received: by 2002:a1c:2985:: with SMTP id p127mr7390963wmp.165.1621581759653; Fri, 21 May 2021 00:22:39 -0700 (PDT) Received: from dell ([91.110.221.215]) by smtp.gmail.com with ESMTPSA id c15sm1041514wro.21.2021.05.21.00.22.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 00:22:39 -0700 (PDT) Date: Fri, 21 May 2021 08:22:36 +0100 From: Lee Jones To: Arnd Bergmann Cc: Linux Kernel Mailing List , Benjamin Herrenschmidt , Bob Picco , Clemens Ladisch , "C. Scott Ananian" , "cs.c" , Dave Safford , David Airlie , David Woodhouse , Greg Kroah-Hartman , Harald Welte , Herbert Xu , Jarkko Sakkinen , "Jason A. Donenfeld" , Jason Gunthorpe , Jerome Glisse , Kanoj Sarcar , Kylene Hall , Lijun Pan , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , linux-integrity@vger.kernel.org, linuxppc-dev , Matt Mackall , Michael Ellerman , Michael Neuling , Paul Fulghum , Paul Mackerras , Peter Huewe , Reiner Sailer , Theodore Ts'o , Thirupathaiah Annapureddy , Tyrel Datwyler , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , van Doorn Subject: Re: [PATCH 00/16] Rid W=1 warnings from Char Message-ID: <20210521072236.GX2549456@dell> References: <20210520121347.3467794-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 May 2021, Arnd Bergmann wrote: > On Thu, May 20, 2021 at 2:13 PM Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Lee Jones (16): > > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > > char: random: Include header containing our prototypes > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > > 'byte_reset_it' > > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > > char: agp: backend: Demote some non-conformant kernel-doc headers > > char: agp: frontend: Include header file containing our prototypes > > char: agp: via-agp: Remove unused variable 'current_size' > > char: hpet: Remove unused variable 'm' > > char: agp: generic: Place braces around optimised out function in if() > > char: agp: uninorth-agp: Remove unused variable 'size' > > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > > char: mem: Provide local prototype for non-static function > > Thanks a lot! > > I've looked all the patches now and commented on patches 6 and 16. > With my comments addressed > > Reviewed-by: Arnd Bergmann Thanks Arnd. Would it be possible for the remaining 14 patches to be taken in please? I will work on the 2 Arnd commented on in due course and resubmit them independently. TIA. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog