From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D17C433B4 for ; Fri, 21 May 2021 07:56:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE9DF611AB for ; Fri, 21 May 2021 07:56:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235159AbhEUH6E (ORCPT ); Fri, 21 May 2021 03:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbhEUH6B (ORCPT ); Fri, 21 May 2021 03:58:01 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC26EC061763 for ; Fri, 21 May 2021 00:56:37 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id a4so20113133wrr.2 for ; Fri, 21 May 2021 00:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ZBzGJGY3Lfdn2lNHI2teoZpXLD66Uih3j/hx8ThIHi4=; b=DYK4allmsvbOxhLePej2gQFrRaKHJlch3k0v7mM00MGfmxSAWTMg/3INJhD+1Rc3tU 9mOKiKUjmwPEf4GRDSP8kNtQuJDR5Y+ZpoiZMFHtiReax+43X/DrDH7OYo0+/5D7/STR uRRZGHQQgnENF2IGZZW38nUi3XD0QEUGfclsvQs5VCyM5/Kb9GX/SnyiQU+Y6BIvzFQf GX0L5Sgxj9RvgHFJFANgnVk4UYQvTAYi5z4Q5wXF1c4tRGb1sqe9ZeDJ0vXhwCiuZvQK yYqwZDP6IcXMQDVHvaLwSV915BV14jdKWLHO0eqPTq1w1tXxRe249C+gWXeC+7JSej3I vO8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ZBzGJGY3Lfdn2lNHI2teoZpXLD66Uih3j/hx8ThIHi4=; b=d7dF9knmAB7kF/+ConAYQmedZ7ODx+VWbIfBeHqV5Qc8GjM7AWiS8YKW5ax5oiFhIs 6Sr7x8TLS4MkJd+T5YXNhmRRidfbaWXVYjgyw6FweXV6/Vm3GN+aPUYZJI14IPBhSLcn 3J8l2glvagVUJcz71WcreTlwyFnWpo/jIY/ggLrBbIZxLRT/yM/wmN6rtfxND7/ZaLtz uzwcDOygTpYb1bMhQzDLapLG2u5Mz+yV9/VDf47z4hHdyDa00hLb6kuf43jd1xxbjR5e YmA8t66PSiZcJ5afo58L7LZsbe1rMIazO9twgQqppXkmkMB5HKlr9YgTsK1knKjU0+60 9o6w== X-Gm-Message-State: AOAM530S5/CsRZB5dj73Xpj63IetjrDVpypYvKfG6IygevTmPrCmidmo I8ikt4pAgiis8Svg1rCf1Q90Xg== X-Google-Smtp-Source: ABdhPJwx8/gIMGjk4t/5kik01FomXtSQYBs+juxRo4HxzZoCKemokseJo7KzkcOXTh/L7jhS9L6uHA== X-Received: by 2002:adf:f109:: with SMTP id r9mr8360005wro.251.1621583796406; Fri, 21 May 2021 00:56:36 -0700 (PDT) Received: from dell ([91.110.221.215]) by smtp.gmail.com with ESMTPSA id g11sm1133714wri.59.2021.05.21.00.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 00:56:35 -0700 (PDT) Date: Fri, 21 May 2021 08:56:33 +0100 From: Lee Jones To: Greg Kroah-Hartman Cc: Arnd Bergmann , Linux Kernel Mailing List , Benjamin Herrenschmidt , Bob Picco , Clemens Ladisch , "C. Scott Ananian" , "cs.c" , Dave Safford , David Airlie , David Woodhouse , Harald Welte , Herbert Xu , Jarkko Sakkinen , "Jason A. Donenfeld" , Jason Gunthorpe , Jerome Glisse , Kanoj Sarcar , Kylene Hall , Lijun Pan , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , linux-integrity@vger.kernel.org, linuxppc-dev , Matt Mackall , Michael Ellerman , Michael Neuling , Paul Fulghum , Paul Mackerras , Peter Huewe , Reiner Sailer , Theodore Ts'o , Thirupathaiah Annapureddy , Tyrel Datwyler , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , van Doorn Subject: Re: [PATCH 00/16] Rid W=1 warnings from Char Message-ID: <20210521075633.GB2549456@dell> References: <20210520121347.3467794-1-lee.jones@linaro.org> <20210521072236.GX2549456@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 May 2021, Greg Kroah-Hartman wrote: > On Fri, May 21, 2021 at 09:42:29AM +0200, Greg Kroah-Hartman wrote: > > On Fri, May 21, 2021 at 08:22:36AM +0100, Lee Jones wrote: > > > On Thu, 20 May 2021, Arnd Bergmann wrote: > > > > > > > On Thu, May 20, 2021 at 2:13 PM Lee Jones wrote: > > > > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > > kernel builds, which are currently overwhelmingly riddled with > > > > > niggly little warnings. > > > > > > > > > > Lee Jones (16): > > > > > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > > > > > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > > > > > char: random: Include header containing our prototypes > > > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > > > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > > > > > 'byte_reset_it' > > > > > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > > > > > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > > > > > char: agp: backend: Demote some non-conformant kernel-doc headers > > > > > char: agp: frontend: Include header file containing our prototypes > > > > > char: agp: via-agp: Remove unused variable 'current_size' > > > > > char: hpet: Remove unused variable 'm' > > > > > char: agp: generic: Place braces around optimised out function in if() > > > > > char: agp: uninorth-agp: Remove unused variable 'size' > > > > > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > > > > > char: mem: Provide local prototype for non-static function > > > > > > > > Thanks a lot! > > > > > > > > I've looked all the patches now and commented on patches 6 and 16. > > > > With my comments addressed > > > > > > > > Reviewed-by: Arnd Bergmann > > > > > > Thanks Arnd. > > > > > > Would it be possible for the remaining 14 patches to be taken in > > > please? I will work on the 2 Arnd commented on in due course and > > > resubmit them independently. > > > > Yes, I can queue them up, thanks. > > Wait, I can take the ones for code that I maintain, not for others. > drivers/char/ is "fun" in that some subdirs have active > trees/maintainers that are not me and Arnd so they go to Linus through > other ways. I'll queue up the ones that I am "allowed" to and you will > get the emails from that. Understood, thanks. Hopefully the other maintainers will be as on the ball as you are. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog