From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A75BC433B4 for ; Fri, 21 May 2021 10:25:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CED5613BD for ; Fri, 21 May 2021 10:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234546AbhEUK0h (ORCPT ); Fri, 21 May 2021 06:26:37 -0400 Received: from elvis.franken.de ([193.175.24.41]:42956 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhEUK0S (ORCPT ); Fri, 21 May 2021 06:26:18 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lk2Jr-000130-00; Fri, 21 May 2021 12:23:51 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 58C96C101E; Fri, 21 May 2021 12:23:38 +0200 (CEST) Date: Fri, 21 May 2021 12:23:38 +0200 From: Thomas Bogendoerfer To: Sergio Paracuellos , lorenzo.pieralisi@arm.com Cc: Bjorn Helgaas , "open list:MIPS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Matthias Brugger , John Crispin , Bjorn Helgaas , Rob Herring , linux-staging@lists.linux.dev, Greg KH , NeilBrown , Ilya Lipnitskiy , linux-kernel , linux-pci@vger.kernel.org Subject: Re: [PATCH 0/4] MIPS: ralink: pci: driver for Pcie controller in MT7621 SoCs Message-ID: <20210521102338.GA6989@alpha.franken.de> References: <20210515124055.22225-1-sergio.paracuellos@gmail.com> <20210519203628.GA254894@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 19, 2021 at 11:18:36PM +0200, Sergio Paracuellos wrote: > On Wed, May 19, 2021 at 10:36 PM Bjorn Helgaas wrote: > > But most of the similar drivers are in drivers/pci/controller/, where > > I think it's easier to keep them up to date with changes in the PCI > > core. Have you considered putting this one there? > > Most pci drivers in 'arch/mips/pci' are still using PCI_LEGACY stuff. > In contrast mt7621-pci is using current pci generic apis but even most > of the code is generic enough, there is one remaining thing which > depends on mips architecture which is the iocu region configuration > which must be done in the driver itself. This is the only reason to > move this driver into 'arch/mips/pci' instead of > 'drivers/pci/controller/'. So... I am all ears to listen to > suggestions for the proper place for this driver. Thomas, do you have > any thoughts on this? I tried to put a pci-xtalk driver into drivers/pci/controller, but Lorenzo didn't want it there for being MIPS and not DT based. So this one is DT based, but still MIPS. I'm perfectly fine putting this driver into drivers/pci/controller/ Lorenzo, what's your opinion ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]