From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4523C47078 for ; Fri, 21 May 2021 15:02:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFA43613E4 for ; Fri, 21 May 2021 15:02:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237187AbhEUPDr (ORCPT ); Fri, 21 May 2021 11:03:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232049AbhEUPDh (ORCPT ); Fri, 21 May 2021 11:03:37 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 428BCC0613CE for ; Fri, 21 May 2021 08:02:13 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id n2so21475064wrm.0 for ; Fri, 21 May 2021 08:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=iI+XKzlAf3f1hN1QD2LhQTdtVCnY+TpUzlIH07KWlic=; b=M6JM6cQpNzSU4E1Vl9k/reolNw1UiYOoJbJsRHjoSBHcn0JgpnRdxXZO7U0OZd5+MX HMa80350SnG6Rs09OkcxCsHy3135+dFwKX7PE4z2fy+xFdArgDmwue3OeAvAftMRehl3 qaOfNYaXH3yPr6m112hdkADdW8GhVZHuZxwuWLg79jmjo3NCNnX8E4XXpAJa1HxSiX1q xlPQEfym8kXuYVwS+drfoEGZaBUsmZ/3l0gX2yS0su8Dl0Wgv88hWh/y0VYgqcRQD9kt q47jckayZnb6+oKsxp+6vLsDK+aFIixUbrYWiBaJKtKg6wvNuwlac0nPLT2jNWwIy9lN fZRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=iI+XKzlAf3f1hN1QD2LhQTdtVCnY+TpUzlIH07KWlic=; b=by2AEKmhUu3sthv9I2p/Zqp9synqbQDLf6BdskeeFyMhTLSm6wQiVgQ3DlGqaK7M2f /dqbBss/W6jFxQroG+F865J/8nN83244FRNiBfLrMmJQQMXT8Uht/CJCStV+Cqk6J27B LwJ30b+wA+/sMAYHeASDlByp8HKgQBc5z773grE7vbsx0R1w9RJsBc1uzMyTb4j5CZyV zCsmoxQGyv1OQHAQqGJ1WA90qaJ1WDq3INqmMlXbLzEonMd5bvz+C3EzcsSUt1BPj2VO KQky785WDnrDMm0kNlkljLEgliOhdO0MF+P18CGpWa4lpRm9qP42/8411rTwGJzyWArn DfiQ== X-Gm-Message-State: AOAM532agTH0NK4vFfR6dGXaBylDx7CtjBoUO0kz5p6QrGoO1fDX4WiQ Um5XaFPK5FjncuBMCgsM67gjqQ== X-Google-Smtp-Source: ABdhPJx3tewqTMW2RfQyk1ppEHB80rp4tHkrMil5Fg3e3Y8IOq1vGAesVHoKRYWNKzdZ9Lhw95Taeg== X-Received: by 2002:a5d:6485:: with SMTP id o5mr10164241wri.163.1621609331802; Fri, 21 May 2021 08:02:11 -0700 (PDT) Received: from dell ([91.110.221.215]) by smtp.gmail.com with ESMTPSA id s15sm2904308wrt.54.2021.05.21.08.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 08:02:11 -0700 (PDT) Date: Fri, 21 May 2021 16:02:09 +0100 From: Lee Jones To: Min Li Cc: "sameo@linux.intel.com" , "grant.likely@linaro.org" , "robh+dt@kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit (SMU) support Message-ID: <20210521150209.GI2549456@dell> References: <1619466246-11198-1-git-send-email-min.li.xe@renesas.com> <20210519080807.GH805368@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 May 2021, Min Li wrote: > > > > > > +config MFD_RSMU_I2C > > > + tristate "Renesas Synchronization Management Unit with I2C" > > > + depends on I2C && OF > > > + depends on MFD_RSMU_SPI=n > > > > Not sure I've seen a relationship like this before. > > > > Devices capable of SPI and I2C usually have a core driver which selects one > > or the other. It will also save some code duplication you have here. Please > > take a look at some other examples in the MFD subsystem. > > > Hi Lee > > Thanks for taking your time to review my code. I will start working on the core driver. But > Kconfig items will stay as MFD_RSMU_I2C and MFD_RSMU_SPI like the existing ones > > MFD_MADERA_SPI > MFD_MADERA_I2C And MFD_MADERA > MFD_DA9052_SPI > MFD_DA9052_I2C And PMIC_DA9052 > MFD_MC13XXX_SPI > MFD_MC13XXX_I2C And MFD_MC13XXX -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog