From: Luis Chamberlain <mcgrof@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Minchan Kim <minchan@kernel.org>, Hannes Reinecke <hare@suse.de>,
Douglas Gilbert <dgilbert@interlog.com>,
ngupta@vflare.org, sergey.senozhatsky.work@gmail.com,
axboe@kernel.dk, mbenes@suse.com, jpoimboe@redhat.com,
tglx@linutronix.de, keescook@chromium.org, jikos@kernel.org,
rostedt@goodmis.org, peterz@infradead.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] zram: fix few sysfs races
Date: Fri, 21 May 2021 20:16:18 +0000 [thread overview]
Message-ID: <20210521201618.GX4332@42.do-not-panic.com> (raw)
In-Reply-To: <YKgRsCzwp2O2mYcp@kroah.com>
On Fri, May 21, 2021 at 10:01:52PM +0200, Greg Kroah-Hartman wrote:
> On Wed, May 19, 2021 at 08:20:23PM +0000, Luis Chamberlain wrote:
> > Greg,
> >
> > your feedback would be appreciated here.
>
> Appreciated where? This is a zram patchset, what do I need to mess with
> it for?
This patchset has 2 issues which I noted in the last series that are
generic, and could best be dealt with on sysfs, and suggested
how this could actually be dealt with on sysfs / kernfs.
> > Greg, can you comment on technical levels why a general core fix is not
> > desirable upstream for those two issues?
>
> What issues exactly?
When I suggested the generic way to fix this your main argument against
a generic solution was that we don't support module removal. Given that
argument did not seem to hold any water it begs the question if you
still would rather not see this fixed in sysfs / kernfs.
If you however are more open to it now, I can instead take that work, and
send a proper patch for review.
Luis
next prev parent reply other threads:[~2021-05-21 20:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 1:11 [PATCH v2 0/4] zram: fix few sysfs races Luis Chamberlain
2021-04-23 1:11 ` [PATCH v2 1/4] zram: fix crashes due to use of cpu hotplug multistate Luis Chamberlain
2021-05-19 19:54 ` Minchan Kim
2021-04-23 1:11 ` [PATCH v2 2/4] zram: avoid disksize setting when device is being claimed Luis Chamberlain
2021-05-19 19:56 ` Minchan Kim
2021-04-23 1:11 ` [PATCH v2 3/4] zram: fix deadlock with sysfs attribute usage and driver removal Luis Chamberlain
2021-04-23 1:11 ` [PATCH v2 4/4] zram: fix possible races between sysfs use and bdev access Luis Chamberlain
2021-05-19 20:09 ` [PATCH v2 0/4] zram: fix few sysfs races Minchan Kim
2021-05-19 20:20 ` Luis Chamberlain
2021-05-21 20:01 ` Greg Kroah-Hartman
2021-05-21 20:16 ` Luis Chamberlain [this message]
2021-05-21 20:45 ` Greg Kroah-Hartman
2021-05-21 21:08 ` Luis Chamberlain
2021-05-22 7:48 ` Greg Kroah-Hartman
2021-05-25 1:16 ` Luis Chamberlain
2021-05-25 7:41 ` Greg Kroah-Hartman
2021-06-21 23:19 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521201618.GX4332@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=axboe@kernel.dk \
--cc=dgilbert@interlog.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).