From: Shawn Guo <shawnguo@kernel.org>
To: Zou Wei <zou_wei@huawei.com>
Cc: s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, iuliana.prodan@nxp.com,
Anson.Huang@nxp.com, peng.fan@nxp.com, alice.guo@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] soc: imx8m: add missing MODULE_DEVICE_TABLE
Date: Sun, 23 May 2021 11:38:18 +0800 [thread overview]
Message-ID: <20210523033818.GT8194@dragon> (raw)
In-Reply-To: <1620790885-15892-1-git-send-email-zou_wei@huawei.com>
On Wed, May 12, 2021 at 11:41:25AM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
I do not see it supports module build right now.
Shawn
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/soc/imx/soc-imx8m.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
> index 071e144..8debf62 100644
> --- a/drivers/soc/imx/soc-imx8m.c
> +++ b/drivers/soc/imx/soc-imx8m.c
> @@ -186,6 +186,7 @@ static __maybe_unused const struct of_device_id imx8_soc_match[] = {
> { .compatible = "fsl,imx8mp-soc", .data = &imx8mp_soc_data, },
> { }
> };
> +MODULE_DEVICE_TABLE(of, imx8_soc_match);
>
> #define imx8_revision(soc_rev) \
> soc_rev ? \
> --
> 2.6.2
>
prev parent reply other threads:[~2021-05-23 3:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 3:41 [PATCH -next] soc: imx8m: add missing MODULE_DEVICE_TABLE Zou Wei
2021-05-12 7:34 ` Alice Guo (OSS)
2021-05-23 3:38 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210523033818.GT8194@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=alice.guo@nxp.com \
--cc=festevam@gmail.com \
--cc=iuliana.prodan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).