From: YueHaibing <yuehaibing@huawei.com>
To: <miklos@szeredi.hu>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH -next] cuse: use DEVICE_ATTR_*() macros
Date: Sun, 23 May 2021 14:51:52 +0800 [thread overview]
Message-ID: <20210523065152.29632-1-yuehaibing@huawei.com> (raw)
Use DEVICE_ATTR_*() helper instead of plain DEVICE_ATTR,
which makes the code a bit shorter and easier to read.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/fuse/cuse.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs/fuse/cuse.c b/fs/fuse/cuse.c
index c7d882a9fe33..0df886224afe 100644
--- a/fs/fuse/cuse.c
+++ b/fs/fuse/cuse.c
@@ -574,25 +574,25 @@ static struct file_operations cuse_channel_fops; /* initialized during init */
* CUSE exports the same set of attributes to sysfs as fusectl.
*/
-static ssize_t cuse_class_waiting_show(struct device *dev,
- struct device_attribute *attr, char *buf)
+static ssize_t waiting_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
struct cuse_conn *cc = dev_get_drvdata(dev);
return sprintf(buf, "%d\n", atomic_read(&cc->fc.num_waiting));
}
-static DEVICE_ATTR(waiting, 0400, cuse_class_waiting_show, NULL);
+static DEVICE_ATTR_ADMIN_RO(waiting);
-static ssize_t cuse_class_abort_store(struct device *dev,
- struct device_attribute *attr,
- const char *buf, size_t count)
+static ssize_t abort_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
{
struct cuse_conn *cc = dev_get_drvdata(dev);
fuse_abort_conn(&cc->fc);
return count;
}
-static DEVICE_ATTR(abort, 0200, NULL, cuse_class_abort_store);
+static DEVICE_ATTR_WO(abort);
static struct attribute *cuse_class_dev_attrs[] = {
&dev_attr_waiting.attr,
--
2.17.1
next reply other threads:[~2021-05-23 6:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 6:51 YueHaibing [this message]
2021-06-21 8:46 ` [PATCH -next] cuse: use DEVICE_ATTR_*() macros Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210523065152.29632-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).