From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] tools/bootconfig: Fix error return code in apply_xbc()
Date: Sun, 23 May 2021 23:19:06 +0900 [thread overview]
Message-ID: <20210523231906.943ac0367c1c469420f8f812@kernel.org> (raw)
In-Reply-To: <20210514183238.07b96338@gandalf.local.home>
On Fri, 14 May 2021 18:32:38 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Sat, 8 May 2021 11:42:16 +0800
> Zhen Lei <thunder.leizhen@huawei.com> wrote:
>
> > Fix to return a negative error code from the error handling case instead
> > of 0, as done elsewhere in this function.
> >
> > Fixes: a995e6bc0524 ("tools/bootconfig: Fix to check the write failure correctly")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>
> Masami, care to ack this?
Oops, I missed this patch. Sorry.
This looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
>
> -- Steve
>
> > ---
> > tools/bootconfig/main.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/bootconfig/main.c b/tools/bootconfig/main.c
> > index 7362bef1a368..6cd6080cac04 100644
> > --- a/tools/bootconfig/main.c
> > +++ b/tools/bootconfig/main.c
> > @@ -399,6 +399,7 @@ static int apply_xbc(const char *path, const char *xbc_path)
> > }
> > /* TODO: Ensure the @path is initramfs/initrd image */
> > if (fstat(fd, &stat) < 0) {
> > + ret = -errno;
> > pr_err("Failed to get the size of %s\n", path);
> > goto out;
> > }
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2021-05-23 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 3:42 [PATCH 1/1] tools/bootconfig: Fix error return code in apply_xbc() Zhen Lei
2021-05-14 22:32 ` Steven Rostedt
2021-05-23 14:19 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210523231906.943ac0367c1c469420f8f812@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).