From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>,
Andreas Westman Dorcsak <hedmoo@yahoo.com>,
Maxim Schwalm <maxim.schwalm@gmail.com>,
Svyatoslav Ryhel <clamor95@gmail.com>,
Ihor Didenko <tailormoon@rambler.ru>,
Ion Agorria <ion@agorria.com>,
Matt Merhar <mattmerhar@protonmail.com>,
Peter Geis <pgwipeout@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: [PATCH v2 2/7] thermal: thermal_of: Stop zone device before unregistering it
Date: Mon, 24 May 2021 02:56:15 +0300 [thread overview]
Message-ID: <20210523235620.31538-3-digetx@gmail.com> (raw)
In-Reply-To: <20210523235620.31538-1-digetx@gmail.com>
Zone device is enabled after thermal_zone_of_sensor_register() completion,
but it's not disabled before senors if unregistered, leaving temperature
polling active. This results in accessing a disabled zone device and
produces a warning about this problem. Stop zone device before
unregistering it in order to fix this "use-after-free" problem.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/thermal/thermal_of.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
index 5b76f9a1280d..6379f26a335f 100644
--- a/drivers/thermal/thermal_of.c
+++ b/drivers/thermal/thermal_of.c
@@ -559,6 +559,9 @@ void thermal_zone_of_sensor_unregister(struct device *dev,
if (!tz)
return;
+ /* stop temperature polling */
+ thermal_zone_device_disable(tzd);
+
mutex_lock(&tzd->lock);
tzd->ops->get_temp = NULL;
tzd->ops->get_trend = NULL;
--
2.30.2
next prev parent reply other threads:[~2021-05-23 23:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 23:56 [PATCH v2 0/7] Add driver for NVIDIA Tegra30 SoC Thermal sensor Dmitry Osipenko
2021-05-23 23:56 ` [PATCH v2 1/7] dt-bindings: thermal: Add binding for Tegra30 thermal sensor Dmitry Osipenko
2021-05-23 23:56 ` Dmitry Osipenko [this message]
2021-05-23 23:56 ` [PATCH v2 3/7] thermal/core: Export thermal_cooling_device_stats_update() Dmitry Osipenko
2021-05-23 23:56 ` [PATCH v2 4/7] thermal/drivers/tegra: Add driver for Tegra30 thermal sensor Dmitry Osipenko
2021-05-23 23:56 ` [PATCH v2 5/7] ARM: tegra_defconfig: Enable CONFIG_TEGRA30_TSENSOR Dmitry Osipenko
2021-05-23 23:56 ` [PATCH v2 6/7] ARM: multi_v7_defconfig: " Dmitry Osipenko
2021-05-23 23:56 ` [PATCH v2 7/7] ARM: tegra: Add SoC thermal sensor to Tegra30 device-trees Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210523235620.31538-3-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=amitk@kernel.org \
--cc=clamor95@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hedmoo@yahoo.com \
--cc=ion@agorria.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=maxim.schwalm@gmail.com \
--cc=pgwipeout@gmail.com \
--cc=rui.zhang@intel.com \
--cc=tailormoon@rambler.ru \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).