From: Jason Gunthorpe <jgg@nvidia.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: alex.williamson@redhat.com, kwankhede@nvidia.com,
tglx@linutronix.de, vkoul@kernel.org, megha.dey@intel.com,
jacob.jun.pan@intel.com, ashok.raj@intel.com, yi.l.liu@intel.com,
baolu.lu@intel.com, kevin.tian@intel.com,
sanjay.k.kumar@intel.com, tony.luck@intel.com,
dan.j.williams@intel.com, eric.auger@redhat.com,
pbonzini@redhat.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v6 05/20] vfio: mdev: common lib code for setting up Interrupt Message Store
Date: Sun, 23 May 2021 21:02:57 -0300 [thread overview]
Message-ID: <20210524000257.GN1002214@nvidia.com> (raw)
In-Reply-To: <162164277624.261970.7989190254803052804.stgit@djiang5-desk3.ch.intel.com>
On Fri, May 21, 2021 at 05:19:36PM -0700, Dave Jiang wrote:
> Add common helper code to setup IMS once the MSI domain has been
> setup by the device driver. The main helper function is
> mdev_ims_set_msix_trigger() that is called by the VFIO ioctl
> VFIO_DEVICE_SET_IRQS. The function deals with the setup and
> teardown of emulated and IMS backed eventfd that gets exported
> to the guest kernel via VFIO as MSIX vectors.
>
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/vfio/mdev/Kconfig | 12 ++
> drivers/vfio/mdev/Makefile | 3
> drivers/vfio/mdev/mdev_irqs.c | 318 +++++++++++++++++++++++++++++++++++++++++
> include/linux/mdev.h | 51 +++++++
> 4 files changed, 384 insertions(+)
> create mode 100644 drivers/vfio/mdev/mdev_irqs.c
IMS is not mdev specific, do not entangle it with mdev code. This
should be generic VFIO stuff.
> +static int mdev_msix_set_vector_signal(struct mdev_irq *mdev_irq, int vector, int fd)
> +{
> + int rc, irq;
> + struct mdev_device *mdev = irq_to_mdev(mdev_irq);
> + struct mdev_irq_entry *entry;
> + struct device *dev = &mdev->dev;
> + struct eventfd_ctx *trigger;
> + char *name;
> + bool pasid_en;
> + u32 auxval;
> +
> + if (vector < 0 || vector >= mdev_irq->num)
> + return -EINVAL;
> +
> + entry = &mdev_irq->irq_entries[vector];
> +
> + if (entry->ims)
> + irq = dev_msi_irq_vector(dev, entry->ims_id);
> + else
> + irq = 0;
> +
> + pasid_en = mdev_irq->pasid != INVALID_IOASID ? true : false;
> +
> + /* IMS and invalid pasid is not a valid configuration */
> + if (entry->ims && !pasid_en)
> + return -EINVAL;
> +
> + if (entry->trigger) {
> + if (irq) {
> + irq_bypass_unregister_producer(&entry->producer);
> + free_irq(irq, entry->trigger);
> + if (pasid_en) {
> + auxval = ims_ctrl_pasid_aux(0, false);
> + irq_set_auxdata(irq, IMS_AUXDATA_CONTROL_WORD, auxval);
> + }
> + }
> + kfree(entry->name);
> + eventfd_ctx_put(entry->trigger);
> + entry->trigger = NULL;
> + }
> +
> + if (fd < 0)
> + return 0;
> +
> + name = kasprintf(GFP_KERNEL, "vfio-mdev-irq[%d](%s)", vector, dev_name(dev));
> + if (!name)
> + return -ENOMEM;
> +
> + trigger = eventfd_ctx_fdget(fd);
> + if (IS_ERR(trigger)) {
> + kfree(name);
> + return PTR_ERR(trigger);
> + }
> +
> + entry->name = name;
> + entry->trigger = trigger;
> +
> + if (!irq)
> + return 0;
> +
> + if (pasid_en) {
> + auxval = ims_ctrl_pasid_aux(mdev_irq->pasid, true);
> + rc = irq_set_auxdata(irq, IMS_AUXDATA_CONTROL_WORD, auxval);
> + if (rc < 0)
> + goto err;
Why is anything to do with PASID here? Something has gone wrong with
the layers I suspect..
Oh yes. drivers/irqchip/irq-ims-msi.c is dxd specific and shouldn't be
pretending to be common code.
The protocol to stuff the pasid and other stuff into the auxdata is
also compeltely idxd specific and is just a hacky way to communicate
from this code to the IDXD irq-chip.
So this doesn't belong here either. Pass in the auxdata from the idxd
code and I'd rename the irq-ims-msi to irq-ims-idxd
> +static int mdev_msix_enable(struct mdev_irq *mdev_irq, int nvec)
> +{
> + struct mdev_device *mdev = irq_to_mdev(mdev_irq);
> + struct device *dev;
> + int rc;
> +
> + if (nvec != mdev_irq->num)
> + return -EINVAL;
> +
> + if (mdev_irq->ims_num) {
> + dev = &mdev->dev;
> + rc = msi_domain_alloc_irqs(dev_get_msi_domain(dev), dev, mdev_irq->ims_num);
Huh? The PCI device should be the only device touching IRQ stuff. I'm
nervous to see you mix in the mdev struct device into this function.
Isn't the msi_domain just idxd->ims_domain?
Jason
next prev parent reply other threads:[~2021-05-24 0:03 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 0:19 [PATCH v6 00/20] Add VFIO mediated device support and DEV-MSI support for the idxd driver Dave Jiang
2021-05-22 0:19 ` [PATCH v6 01/20] vfio/mdev: idxd: add theory of operation documentation for idxd mdev Dave Jiang
2021-05-22 0:19 ` [PATCH v6 02/20] dmaengine: idxd: add external module driver support for dsa_bus_type Dave Jiang
2021-05-22 0:19 ` [PATCH v6 03/20] dmaengine: idxd: add IMS offset and size retrieval code Dave Jiang
2021-05-22 0:19 ` [PATCH v6 04/20] dmaengine: idxd: add portal offset for IMS portals Dave Jiang
2021-05-22 0:19 ` [PATCH v6 05/20] vfio: mdev: common lib code for setting up Interrupt Message Store Dave Jiang
2021-05-24 0:02 ` Jason Gunthorpe [this message]
2021-05-28 1:49 ` Dave Jiang
2021-05-28 12:21 ` Jason Gunthorpe
2021-05-28 16:37 ` Dave Jiang
2021-05-28 16:39 ` Jason Gunthorpe
2021-05-31 10:41 ` Thomas Gleixner
2021-05-31 13:48 ` Thomas Gleixner
2021-05-31 15:24 ` Jason Gunthorpe
2021-06-08 15:57 ` Dave Jiang
2021-06-08 17:22 ` Jason Gunthorpe
2021-06-10 13:00 ` Thomas Gleixner
2021-05-22 0:19 ` [PATCH v6 06/20] vfio/mdev: idxd: add PCI config for read/write for mdev Dave Jiang
2021-05-22 0:19 ` [PATCH v6 07/20] vfio/mdev: idxd: Add administrative commands emulation " Dave Jiang
2021-05-22 0:19 ` [PATCH v6 08/20] vfio/mdev: idxd: Add mdev device context initialization Dave Jiang
2021-05-22 0:20 ` [PATCH v6 09/20] vfio/mdev: Add mmio read/write support for mdev Dave Jiang
2021-05-22 0:20 ` [PATCH v6 10/20] vfio/mdev: idxd: add mdev type as a new wq type Dave Jiang
2021-05-22 0:20 ` [PATCH v6 11/20] vfio/mdev: idxd: Add basic driver setup for idxd mdev Dave Jiang
2021-05-23 23:27 ` Jason Gunthorpe
2021-05-23 23:52 ` Jason Gunthorpe
2021-05-22 0:20 ` [PATCH v6 12/20] vfio: move VFIO PCI macros to common header Dave Jiang
2021-06-04 3:47 ` Alex Williamson
2021-05-22 0:20 ` [PATCH v6 13/20] vfio/mdev: idxd: add mdev driver registration and helper functions Dave Jiang
2021-05-23 23:32 ` Jason Gunthorpe
2021-05-23 23:46 ` Jason Gunthorpe
2021-05-22 0:20 ` [PATCH v6 14/20] vfio/mdev: idxd: add 1dwq-v1 mdev type Dave Jiang
2021-05-23 23:47 ` Jason Gunthorpe
2021-05-22 0:20 ` [PATCH v6 15/20] vfio/mdev: idxd: ims domain setup for the vdcm Dave Jiang
2021-05-23 23:50 ` Jason Gunthorpe
2021-05-27 0:22 ` Dave Jiang
2021-05-27 0:54 ` Jason Gunthorpe
2021-05-27 1:15 ` Dave Jiang
2021-05-27 1:41 ` Raj, Ashok
2021-05-27 13:36 ` Jason Gunthorpe
2021-05-31 14:02 ` Thomas Gleixner
2021-05-31 16:57 ` Jason Gunthorpe
2021-05-31 23:55 ` Thomas Gleixner
2021-06-01 12:16 ` Jason Gunthorpe
2021-05-22 0:20 ` [PATCH v6 16/20] vfio/mdev: idxd: add new wq state for mdev Dave Jiang
2021-05-22 0:20 ` [PATCH v6 17/20] vfio/mdev: idxd: add error notification from host driver to mediated device Dave Jiang
2021-05-22 0:20 ` [PATCH v6 18/20] vfio: move vfio_pci_set_ctx_trigger_single to common code Dave Jiang
2021-05-22 0:21 ` [PATCH v6 19/20] vfio: mdev: Add device request interface Dave Jiang
2021-05-23 22:38 ` Jason Gunthorpe
2021-05-22 0:21 ` [PATCH v6 20/20] vfio: mdev: idxd: setup request interrupt Dave Jiang
2021-05-23 23:22 ` [PATCH v6 00/20] Add VFIO mediated device support and DEV-MSI support for the idxd driver Jason Gunthorpe
2021-06-02 15:40 ` Dave Jiang
2021-06-02 23:17 ` Jason Gunthorpe
2021-06-03 1:11 ` Tian, Kevin
2021-06-03 1:49 ` Jason Gunthorpe
2021-06-03 5:52 ` Tian, Kevin
2021-06-03 11:23 ` Jason Gunthorpe
2021-06-04 3:40 ` Alex Williamson
2021-06-07 6:22 ` Tian, Kevin
2021-06-07 18:13 ` Dave Jiang
2021-06-07 19:11 ` Jason Gunthorpe
2021-06-08 16:02 ` Dave Jiang
2021-06-11 18:21 ` Dave Jiang
2021-06-11 18:29 ` Jason Gunthorpe
2021-06-07 18:28 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524000257.GN1002214@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.auger@redhat.com \
--cc=jacob.jun.pan@intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=megha.dey@intel.com \
--cc=pbonzini@redhat.com \
--cc=sanjay.k.kumar@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).