From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>, Hans Verkuil <hverkuil@xs4all.nl>,
Christoph Hellwig <hch@lst.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] media: atomisp: remove compat_ioctl32 code
Date: Mon, 24 May 2021 18:18:29 +0300 [thread overview]
Message-ID: <20210524151829.GO3@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20210516204818.2967910-1-arnd@kernel.org>
Hi Arnd,
On Sun, May 16, 2021 at 10:47:43PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This is one of the last remaining users of compat_alloc_user_space()
> and copy_in_user(), which are in the process of getting removed.
>
> As of commit 57e6b6f2303e ("media: atomisp_fops.c: disable
> atomisp_compat_ioctl32"), nothing in this file is actually getting used
> as the only reference has been stubbed out.
This patch was made redundant by another one that fixed the bug. But I
guess you're right in the sense that no-one could have used this because of
the patch that disabled it.
So:
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
But:
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c
> index f1e6b2597853..e383e17c5072 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_fops.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c
> @@ -1283,7 +1283,8 @@ const struct v4l2_file_operations atomisp_fops = {
> .unlocked_ioctl = video_ioctl2,
> #ifdef CONFIG_COMPAT
> /*
> - * There are problems with this code. Disable this for now.
> + * this was removed because of bugs, the interface
> + * needs to be made safe for compat tasks instead.
> .compat_ioctl32 = atomisp_compat_ioctl32,
I think the comment could go, too.
> */
> #endif
> @@ -1297,10 +1298,7 @@ const struct v4l2_file_operations atomisp_file_fops = {
> .mmap = atomisp_file_mmap,
> .unlocked_ioctl = video_ioctl2,
> #ifdef CONFIG_COMPAT
> - /*
> - * There are problems with this code. Disable this for now.
> - .compat_ioctl32 = atomisp_compat_ioctl32,
> - */
> + /* .compat_ioctl32 = atomisp_compat_ioctl32, */
Thie one, too.
> #endif
> .poll = atomisp_poll,
> };
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2021-05-24 15:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 20:47 [PATCH] media: atomisp: remove compat_ioctl32 code Arnd Bergmann
2021-05-17 7:10 ` Andy Shevchenko
2021-05-17 13:04 ` David Laight
2021-05-17 13:08 ` Christoph Hellwig
2021-05-17 13:30 ` Arnd Bergmann
2021-05-24 15:18 ` Sakari Ailus [this message]
2021-05-28 7:19 ` Arnd Bergmann
2021-05-28 9:56 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524151829.GO3@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).