From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <pmladek@suse.com>, <rostedt@goodmis.org>,
<sergey.senozhatsky@gmail.com>,
<andriy.shevchenko@linux.intel.com>, <linux@rasmusvillemoes.dk>,
<w@1wt.eu>, <lkml@sdf.org>, <davem@davemloft.net>,
<kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>
Subject: [PATCH 0/2] Fix truncation warnings from building test_scanf.c
Date: Mon, 24 May 2021 16:59:39 +0100 [thread overview]
Message-ID: <20210524155941.16376-1-rf@opensource.cirrus.com> (raw)
The kernel test robot is reporting truncation warnings when building
lib/test_scanf.c:
1) lib/test_scanf.c:250:9: sparse: sparse: cast truncates bits from
constant value (ffff0001 becomes 1)
Reported on several lines.
2) include/linux/prandom.h:114:45: sparse: sparse: cast truncates bits
from constant value (4f2e5357408c3c09 becomes 408c3c09)
(1) is caused by test_scanf.c using type_min() on an unsigned type. The
type_min() macro calculates -type_max() - 1, so is only meaningful for
signed types.
(2) is caused by prandom_seed_state() storing a modified u64 seed value
into a u32 - sparse will warn that this causes a truncation.
The two patches in this series fix these problems.
Richard Fitzgerald (2):
lib: test_scanf: Fix incorrect use of type_min() with unsigned types
random32: Fix implicit truncation warning in prandom_seed_state()
include/linux/prandom.h | 2 +-
lib/test_scanf.c | 13 ++++++-------
2 files changed, 7 insertions(+), 8 deletions(-)
--
2.20.1
next reply other threads:[~2021-05-24 16:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 15:59 Richard Fitzgerald [this message]
2021-05-24 15:59 ` [PATCH 1/2] lib: test_scanf: Fix incorrect use of type_min() with unsigned types Richard Fitzgerald
2021-05-25 9:55 ` Rasmus Villemoes
2021-05-25 10:10 ` Richard Fitzgerald
2021-05-25 10:30 ` Rasmus Villemoes
2021-05-27 21:59 ` Luc Van Oostenryck
2021-05-24 15:59 ` [PATCH 2/2] random32: Fix implicit truncation warning in prandom_seed_state() Richard Fitzgerald
2021-05-25 9:20 ` [PATCH 0/2] Fix truncation warnings from building test_scanf.c Petr Mladek
2021-05-27 14:10 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524155941.16376-1-rf@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lkml@sdf.org \
--cc=netdev@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).