From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E73CC47086 for ; Tue, 25 May 2021 08:21:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51ED2611C9 for ; Tue, 25 May 2021 08:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232298AbhEYIW2 convert rfc822-to-8bit (ORCPT ); Tue, 25 May 2021 04:22:28 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:5549 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230370AbhEYIWZ (ORCPT ); Tue, 25 May 2021 04:22:25 -0400 Received: from dggems706-chm.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Fq6Qg0hHrzwSnk; Tue, 25 May 2021 16:18:03 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by dggems706-chm.china.huawei.com (10.3.19.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 25 May 2021 16:20:53 +0800 Received: from localhost (10.52.120.147) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 25 May 2021 09:20:51 +0100 Date: Tue, 25 May 2021 09:19:02 +0100 From: Jonathan Cameron To: "Li, Meng" CC: Jonathan Cameron , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , "lars@metafoo.de" , "Michael.Hennerich@analog.com" , "pmeerw@pmeerw.net" , "linux-kernel@vger.kernel.org" , "linux-iio@vger.kernel.org" Subject: Re: [PATCH] driver: adc: ltc2497: return directly after reading the adc conversion value Message-ID: <20210525091902.000074b5@Huawei.com> In-Reply-To: References: <20210512045725.23390-1-Meng.Li@windriver.com> <20210519092104.pntanimcjg6s6fca@pengutronix.de> <20210521180150.0f4d1b5d@jic23-huawei> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.52.120.147] X-ClientProxiedBy: lhreml705-chm.china.huawei.com (10.201.108.54) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 May 2021 02:49:01 +0000 "Li, Meng" wrote: > > -----Original Message----- > > From: Jonathan Cameron > > Sent: Saturday, May 22, 2021 1:02 AM > > To: Uwe Kleine-König > > Cc: Li, Meng ; lars@metafoo.de; > > Michael.Hennerich@analog.com; pmeerw@pmeerw.net; linux- > > kernel@vger.kernel.org; linux-iio@vger.kernel.org > > Subject: Re: [PATCH] driver: adc: ltc2497: return directly after reading the adc > > conversion value > > > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > On Wed, 19 May 2021 11:21:04 +0200 > > Uwe Kleine-König wrote: > > > > > On Wed, May 12, 2021 at 12:57:25PM +0800, Meng.Li@windriver.com > > wrote: > > > > From: Meng Li > > > > > > > > When read adc conversion value with below command: > > > > cat /sys/.../iio:device0/in_voltage0-voltage1_raw > > > > There is an error reported as below: > > > > ltc2497 0-0014: i2c transfer failed: -EREMOTEIO This i2c transfer > > > > issue is introduced by commit 69548b7c2c4f ("iio: > > > > adc: ltc2497: split protocol independent part in a separate module"). > > > > When extract the common code into ltc2497-core.c, it change the code > > > > logic of function ltc2497core_read(). With wrong reading sequence, > > > > the action of enable adc channel is sent to chip again during adc > > > > channel is in conversion status. In this way, there is no ack from > > > > chip, and then cause i2c transfer failed. > > > > In order to keep the code logic is the same with original ideal, it > > > > is need to return direct after reading the adc conversion value. > > > > > > > > Fixes: 69548b7c2c4f ("iio: adc: ltc2497: split protocol independent > > > > part in a separate module ") > > > > Cc: stable@vger.kernel.org > > > > Signed-off-by: Meng Li > > > > --- > > > > drivers/iio/adc/ltc2497.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/iio/adc/ltc2497.c b/drivers/iio/adc/ltc2497.c > > > > index 1adddf5a88a9..fd5a66860a47 100644 > > > > --- a/drivers/iio/adc/ltc2497.c > > > > +++ b/drivers/iio/adc/ltc2497.c > > > > @@ -41,6 +41,8 @@ static int ltc2497_result_and_measure(struct > > ltc2497core_driverdata *ddata, > > > > } > > > > > > > > *val = (be32_to_cpu(st->buf) >> 14) - (1 << 17); > > > > + > > > > + return ret; > > > > > > This looks wrong for me. The idea of the function > > > ltc2497_result_and_measure is that it reads the result and starts a > > > new measurement. I guess the problem is that > > > ltc2497_result_and_measure is called to early, not that it does too much. > > > > > > But note I don't have such a system handy to actually debug this any > > > more. > > > > @Meng Li, > > > > I see from the datasheet that the device can be used with an external > > oscillator. > > Is that the case on your boards, because if so the timing delay of 150msecs > > may be far too short. If not, perhaps the part is right at the upper end of > > timings and we just need to add 20% to the 150msecs to be sure of not > > hitting the limit? > > > > Hi Jonathan, > > Thanks for your very professional comments. > I check my board schematics, the pin 35 f0 is connected to GND, so I use the internal oscillator. Bad guess :( > In additional, I am not very understand your comment about the case of using internal oscillator. > Do you mean that you agree my patch and only need to change 150 into 180? > #define LTC2497_CONVERSION_TIME_MS 150ULL > => > #define LTC2497_CONVERSION_TIME_MS 180ULL Yes. Just give a little more time in case the oscillator is running a little slow. Jonathan > > Thanks, > Limeng > > > Thanks, > > > > Jonathan > > > > > > > > > > Best regards > > > Uwe > > > >