From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF3AC2B9F8 for ; Tue, 25 May 2021 10:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A11661181 for ; Tue, 25 May 2021 10:34:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232137AbhEYKgL (ORCPT ); Tue, 25 May 2021 06:36:11 -0400 Received: from mailout1.secunet.com ([62.96.220.44]:45992 "EHLO mailout1.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232394AbhEYKdr (ORCPT ); Tue, 25 May 2021 06:33:47 -0400 X-Greylist: delayed 498 seconds by postgrey-1.27 at vger.kernel.org; Tue, 25 May 2021 06:33:47 EDT Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) by mailout1.secunet.com (Postfix) with ESMTP id B894C800056; Tue, 25 May 2021 12:23:56 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 25 May 2021 12:23:56 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 25 May 2021 12:23:56 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 0C0AB3180299; Tue, 25 May 2021 12:23:56 +0200 (CEST) Date: Tue, 25 May 2021 12:23:55 +0200 From: Steffen Klassert To: Yang Li CC: , , , , , , Subject: Re: [PATCH] esp: drop unneeded assignment in esp4_gro_receive() Message-ID: <20210525102355.GW40979@gauss3.secunet.de> References: <1619345672-31802-1-git-send-email-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1619345672-31802-1-git-send-email-yang.lee@linux.alibaba.com> X-ClientProxiedBy: cas-essen-01.secunet.de (10.53.40.201) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 25, 2021 at 06:14:32PM +0800, Yang Li wrote: > Making '!=' operation with 0 directly after calling > the function xfrm_parse_spi() is more efficient, > assignment to err is redundant. > > Eliminate the following clang_analyzer warning: > net/ipv4/esp4_offload.c:41:7: warning: Although the value stored to > 'err' is used in the enclosing expression, the value is never actually > read from 'err' > > No functional change, only more efficient. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Now applied to ipsec-next, thanks!