From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C54C2B9F8 for ; Tue, 25 May 2021 13:04:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCED661420 for ; Tue, 25 May 2021 13:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233023AbhEYNGK (ORCPT ); Tue, 25 May 2021 09:06:10 -0400 Received: from outbound-smtp27.blacknight.com ([81.17.249.195]:46696 "EHLO outbound-smtp27.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232862AbhEYNGJ (ORCPT ); Tue, 25 May 2021 09:06:09 -0400 Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp27.blacknight.com (Postfix) with ESMTPS id ADA3CCACD6 for ; Tue, 25 May 2021 14:04:38 +0100 (IST) Received: (qmail 31438 invoked from network); 25 May 2021 13:04:38 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.23.168]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 25 May 2021 13:04:38 -0000 Date: Tue, 25 May 2021 14:04:36 +0100 From: Mel Gorman To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim , Sebastian Andrzej Siewior , Thomas Gleixner , Jesper Dangaard Brouer , Peter Zijlstra , Jann Horn Subject: Re: [RFC 10/26] mm, slub: do initial checks in ___slab_alloc() with irqs enabled Message-ID: <20210525130436.GS30378@techsingularity.net> References: <20210524233946.20352-1-vbabka@suse.cz> <20210524233946.20352-11-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210524233946.20352-11-vbabka@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 25, 2021 at 01:39:30AM +0200, Vlastimil Babka wrote: > As another step of shortening irq disabled sections in ___slab_alloc(), don't > disable irqs until doing initial checks if there is a cached percpu slab and > it's suitable for our allocation. > > Now we have to recheck c->page after actually disabling irqs as an allocation > in irq might have replaced it. > > Signed-off-by: Vlastimil Babka Minor nit only -- consider adding a comment at the new_slab label that IRQs must be disabled already. Acked-by: Mel Gorman -- Mel Gorman SUSE Labs