* [PATCH v2] nfc: st95hf: remove unnecessary assignment and label
@ 2021-05-26 0:56 samirweng1979
2021-05-26 13:56 ` Krzysztof Kozlowski
2021-05-26 20:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: samirweng1979 @ 2021-05-26 0:56 UTC (permalink / raw)
To: krzysztof.kozlowski, davem, dinghao.liu
Cc: linux-nfc, netdev, linux-kernel, wengjianfeng
From: wengjianfeng <wengjianfeng@yulong.com>
In function st95hf_in_send_cmd, the variable rc is assigned then goto
error label, which just returns rc, so we use return to replace it.
Since error label only used once in the function, so we remove error label.
Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
---
drivers/nfc/st95hf/core.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/nfc/st95hf/core.c b/drivers/nfc/st95hf/core.c
index 4578547..88924be 100644
--- a/drivers/nfc/st95hf/core.c
+++ b/drivers/nfc/st95hf/core.c
@@ -926,10 +926,8 @@ static int st95hf_in_send_cmd(struct nfc_digital_dev *ddev,
int len_data_to_tag = 0;
skb_resp = nfc_alloc_recv_skb(MAX_RESPONSE_BUFFER_SIZE, GFP_KERNEL);
- if (!skb_resp) {
- rc = -ENOMEM;
- goto error;
- }
+ if (!skb_resp)
+ return -ENOMEM;
switch (stcontext->current_rf_tech) {
case NFC_DIGITAL_RF_TECH_106A:
@@ -986,7 +984,6 @@ static int st95hf_in_send_cmd(struct nfc_digital_dev *ddev,
free_skb_resp:
kfree_skb(skb_resp);
-error:
return rc;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] nfc: st95hf: remove unnecessary assignment and label
2021-05-26 0:56 [PATCH v2] nfc: st95hf: remove unnecessary assignment and label samirweng1979
@ 2021-05-26 13:56 ` Krzysztof Kozlowski
2021-05-26 20:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-26 13:56 UTC (permalink / raw)
To: samirweng1979, davem, dinghao.liu
Cc: linux-nfc, netdev, linux-kernel, wengjianfeng
On 25/05/2021 20:56, samirweng1979 wrote:
> From: wengjianfeng <wengjianfeng@yulong.com>
>
> In function st95hf_in_send_cmd, the variable rc is assigned then goto
> error label, which just returns rc, so we use return to replace it.
> Since error label only used once in the function, so we remove error label.
>
> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
> ---
> drivers/nfc/st95hf/core.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] nfc: st95hf: remove unnecessary assignment and label
2021-05-26 0:56 [PATCH v2] nfc: st95hf: remove unnecessary assignment and label samirweng1979
2021-05-26 13:56 ` Krzysztof Kozlowski
@ 2021-05-26 20:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-05-26 20:20 UTC (permalink / raw)
To: samirweng1979
Cc: krzysztof.kozlowski, davem, dinghao.liu, linux-nfc, netdev,
linux-kernel, wengjianfeng
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 26 May 2021 08:56:51 +0800 you wrote:
> From: wengjianfeng <wengjianfeng@yulong.com>
>
> In function st95hf_in_send_cmd, the variable rc is assigned then goto
> error label, which just returns rc, so we use return to replace it.
> Since error label only used once in the function, so we remove error label.
>
> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
>
> [...]
Here is the summary with links:
- [v2] nfc: st95hf: remove unnecessary assignment and label
https://git.kernel.org/netdev/net-next/c/568e7142a15f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-26 20:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 0:56 [PATCH v2] nfc: st95hf: remove unnecessary assignment and label samirweng1979
2021-05-26 13:56 ` Krzysztof Kozlowski
2021-05-26 20:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).