linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-m68k@lists.linux-m68k.org, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] m68k: Drop duplicate "core-y += arch/m68k/" rule causing link failures
Date: Wed, 26 May 2021 10:45:36 +0200	[thread overview]
Message-ID: <20210526084536.1454449-1-geert@linux-m68k.org> (raw)

    Makefile:1949: target 'arch/m68k' given more than once in the same rule
    [...]
      LD      vmlinux.o
    m68k-linux-gnu-ld: arch/m68k/kernel/entry.o: in function `system_call':
    (.text+0x160): multiple definition of `system_call'; arch/m68k/kernel/entry.o:(.text+0x160): first defined here
    [...]

All "core-y += arch/<arch>/" rules were dropped from the corresponding
arch/<arch>/Makefiles, but m68k was forgotten.

Reported-by: noreply@ellerman.id.au
Fixes: 7d9677835b10b5de ("kbuild: require all architectures to have arch/$(SRCARCH)/Kbuild")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 arch/m68k/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/m68k/Makefile b/arch/m68k/Makefile
index c54055a3d28450aa..dd0c0ec67f67064d 100644
--- a/arch/m68k/Makefile
+++ b/arch/m68k/Makefile
@@ -97,7 +97,6 @@ head-$(CONFIG_SUN3)		:= arch/m68k/kernel/sun3-head.o
 head-$(CONFIG_M68000)		:= arch/m68k/68000/head.o
 head-$(CONFIG_COLDFIRE)		:= arch/m68k/coldfire/head.o
 
-core-y				+= arch/m68k/
 libs-y				+= arch/m68k/lib/
 
 
-- 
2.25.1


             reply	other threads:[~2021-05-26  8:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  8:45 Geert Uytterhoeven [this message]
2021-05-26 14:23 ` [PATCH] m68k: Drop duplicate "core-y += arch/m68k/" rule causing link failures Masahiro Yamada
2021-05-26 14:51   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526084536.1454449-1-geert@linux-m68k.org \
    --to=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-next@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).