From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E26C47088 for ; Wed, 26 May 2021 09:01:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E53C66128B for ; Wed, 26 May 2021 09:01:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233425AbhEZJCq (ORCPT ); Wed, 26 May 2021 05:02:46 -0400 Received: from outbound-smtp34.blacknight.com ([46.22.139.253]:51741 "EHLO outbound-smtp34.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233464AbhEZJCi (ORCPT ); Wed, 26 May 2021 05:02:38 -0400 Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp34.blacknight.com (Postfix) with ESMTPS id 1BF101C39 for ; Wed, 26 May 2021 10:00:42 +0100 (IST) Received: (qmail 24661 invoked from network); 26 May 2021 09:00:41 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.23.168]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 26 May 2021 09:00:41 -0000 Date: Wed, 26 May 2021 10:00:40 +0100 From: Mel Gorman To: Michal Such?nek Cc: linux-kbuild@vger.kernel.org, Andrew Morton , Andrii Nakryiko , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , open list , Arnaldo Carvalho de Melo , Jiri Olsa , Hritik Vijay , bpf , Linux-Net , Linux-MM , Masahiro Yamada Subject: Re: (BTF) [PATCH] mm/page_alloc: Work around a pahole limitation with zero-sized struct pagesets Message-ID: <20210526090040.GY30378@techsingularity.net> References: <20210526080741.GW30378@techsingularity.net> <20210526083342.GY8544@kitsune.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210526083342.GY8544@kitsune.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 26, 2021 at 10:33:42AM +0200, Michal Such?nek wrote: > > lib/Kconfig.debug | 3 +++ > > mm/page_alloc.c | 11 +++++++++++ > > 2 files changed, 14 insertions(+) > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 678c13967580..f88a155b80a9 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -313,6 +313,9 @@ config DEBUG_INFO_BTF > > config PAHOLE_HAS_SPLIT_BTF > > def_bool $(success, test `$(PAHOLE) --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/'` -ge "119") > > > > +config PAHOLE_HAS_ZEROSIZE_PERCPU_SUPPORT > > + def_bool $(success, test `$(PAHOLE) --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/'` -ge "122") > > + > > This does not seem workable with dummy-tools. > > Do we even have dummy pahole? > I don't think so but if PAHOLE_HAS_ZEROSIZE_PERCPU_SUPPORT is broken for you then the same problem should have happened for the PAHOLE_HAS_SPLIT_BTF check. -- Mel Gorman SUSE Labs