From: Barry Song <song.bao.hua@hisilicon.com>
To: <vincent.guittot@linaro.org>, <mingo@redhat.com>,
<peterz@infradead.org>, <dietmar.eggemann@arm.com>,
<rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>
Cc: <valentin.schneider@arm.com>, <juri.lelli@redhat.com>,
<bristot@redhat.com>, <linux-kernel@vger.kernel.org>,
<guodong.xu@linaro.org>, <yangyicong@huawei.com>,
<tangchengchang@huawei.com>, <linuxarm@huawei.com>,
Barry Song <song.bao.hua@hisilicon.com>
Subject: [PATCH] sched: fair: don't depend on wake_wide if waker and wakee are already in same LLC
Date: Wed, 26 May 2021 21:10:57 +1200 [thread overview]
Message-ID: <20210526091057.1800-1-song.bao.hua@hisilicon.com> (raw)
when waker and wakee are already in the same LLC, it is pointless to worry
about the competition caused by pulling wakee to waker's LLC domain.
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
---
kernel/sched/fair.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 3248e24a90b0..cfb1bd47acc3 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6795,7 +6795,15 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int wake_flags)
new_cpu = prev_cpu;
}
- want_affine = !wake_wide(p) && cpumask_test_cpu(cpu, p->cpus_ptr);
+ /*
+ * we use wake_wide to make smarter pull and avoid cruel
+ * competition because of jam-packed tasks in waker's LLC
+ * domain. But if waker and wakee have been already in
+ * same LLC domain, it seems it is pointless to depend
+ * on wake_wide
+ */
+ want_affine = (cpus_share_cache(cpu, prev_cpu) || !wake_wide(p)) &&
+ cpumask_test_cpu(cpu, p->cpus_ptr);
}
rcu_read_lock();
--
2.25.1
next reply other threads:[~2021-05-26 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 9:10 Barry Song [this message]
2021-05-26 12:15 ` [PATCH] sched: fair: don't depend on wake_wide if waker and wakee are already in same LLC Peter Zijlstra
2021-05-26 21:38 ` Song Bao Hua (Barry Song)
2021-05-27 12:14 ` Mel Gorman
2021-05-31 22:21 ` Song Bao Hua (Barry Song)
2021-06-01 7:59 ` Mel Gorman
2021-06-01 8:09 ` Song Bao Hua (Barry Song)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526091057.1800-1-song.bao.hua@hisilicon.com \
--to=song.bao.hua@hisilicon.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=guodong.xu@linaro.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tangchengchang@huawei.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).