From: Jakub Kicinski <kuba@kernel.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Wei Wang <weiwan@google.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Willem de Bruijn <willemb@google.com>,
virtualization@lists.linux-foundation.org,
Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH v3 4/4] virtio_net: disable cb aggressively
Date: Wed, 26 May 2021 12:39:18 -0700 [thread overview]
Message-ID: <20210526123918.0aef851d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210526082423.47837-5-mst@redhat.com>
On Wed, 26 May 2021 04:24:43 -0400 Michael S. Tsirkin wrote:
> @@ -1605,12 +1608,17 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)
> struct netdev_queue *txq = netdev_get_tx_queue(dev, qnum);
> bool kick = !netdev_xmit_more();
> bool use_napi = sq->napi.weight;
> + unsigned int bytes = skb->len;
FWIW GCC says bytes is unused.
next prev parent reply other threads:[~2021-05-26 19:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 8:24 [PATCH v3 0/4] virtio net: spurious interrupt related fixes Michael S. Tsirkin
2021-05-26 8:24 ` [PATCH v3 1/4] virtio_net: move tx vq operation under tx queue lock Michael S. Tsirkin
2021-05-27 3:41 ` Jason Wang
2021-05-28 22:25 ` Willem de Bruijn
2021-06-09 22:03 ` Michael S. Tsirkin
2021-05-26 8:24 ` [PATCH v3 2/4] virtio_net: move txq wakeups under tx q lock Michael S. Tsirkin
2021-05-27 3:48 ` Jason Wang
2021-05-26 8:24 ` [PATCH v3 3/4] virtio: fix up virtio_disable_cb Michael S. Tsirkin
2021-05-27 4:01 ` Jason Wang
2023-03-30 6:07 ` Xuan Zhuo
2023-03-30 6:44 ` Michael S. Tsirkin
2023-03-30 6:54 ` Xuan Zhuo
2023-03-30 14:04 ` Michael S. Tsirkin
2023-03-31 3:38 ` Xuan Zhuo
2021-05-26 8:24 ` [PATCH v3 4/4] virtio_net: disable cb aggressively Michael S. Tsirkin
2021-05-26 15:15 ` Eric Dumazet
2021-05-26 21:22 ` Willem de Bruijn
2021-05-26 19:39 ` Jakub Kicinski [this message]
2021-05-27 4:09 ` Jason Wang
2023-01-16 13:41 ` Laurent Vivier
2023-01-17 3:48 ` Jason Wang
2021-05-26 15:34 ` [PATCH v3 0/4] virtio net: spurious interrupt related fixes Willem de Bruijn
2021-06-01 2:53 ` Willem de Bruijn
2021-06-09 21:36 ` Willem de Bruijn
2021-06-09 22:59 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526123918.0aef851d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=weiwan@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).