From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 294EDC4708A for ; Wed, 26 May 2021 14:49:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CDE3613B0 for ; Wed, 26 May 2021 14:49:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235073AbhEZOuo (ORCPT ); Wed, 26 May 2021 10:50:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234957AbhEZOum (ORCPT ); Wed, 26 May 2021 10:50:42 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2798C061756 for ; Wed, 26 May 2021 07:49:10 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id m18so1467443wrv.2 for ; Wed, 26 May 2021 07:49:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4yzCAHgH1guS2Y/0Pu674rbF+XBExPOSLFaI2JjAr9o=; b=RzcyMIr4so58tJ/yAtZJpcVi6jfoQjSa78q5+zCUvWhjT8ApP+sC9MGWT0SslIRymM OOUsuUiB8Q8miGAkRv6t1l+V8AguLEnIXkCilfhI3WdUAj4rIjVvfDCX0QeOAob479qK llkmocaP7/SJypt9g96oKJW63enU3yMMfT/6g2bBXJx0X5rlXpoiaDXRmtnelLQgKLng uoIX7m5cRWPdlqNsFOxbphLBe65vbj17DoyKPkAg5PIZ2oXvNrBu4xcoKH3yRYeE5dHi 05Xs/YfPmdCUnBObgfyfvRQ5yUEINyxULpVaHrph4sFjMl3cfWrFsTyI7GgjlDCuGMH5 PWTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4yzCAHgH1guS2Y/0Pu674rbF+XBExPOSLFaI2JjAr9o=; b=FvVM06Sx+6m5PWHTb+D16LCUnM5+OvPntCoruYkhXzHbcJlRhgou24kFI+fdqZONio lmELxi12M9fqr7BUxOK5Ry7DPE+BEDzDCJD5sbGMx7hTHvCOrTugKPeP/YGFcPHAlsgC NYhGvPtW/qzmdJIPfWeuPYMjiCVvw27p99GQ1VV4sUxTMzN2pQ3Orx9MJ6av0Ui6AHc+ Olxt1twiAVdTOXHYnqsCWZwOXVke65Sm+BRKzd7GYHTaSWcmC7r+0eUiPmZ551cv1sKs I5pE0oRAHsCJ/0S5+9DDyrY6krLduADPPQUkhK7JY1RmrqYv0WvZzngEHx+ij1OkQvGp tYtQ== X-Gm-Message-State: AOAM533fJbtqoIgxjPn2OMn4xAC+Gp1VOMS7gtZa7TVrsJbhQeM3b4y6 7edx4uzlS+7CCGt9a+Kv6vVpcQ== X-Google-Smtp-Source: ABdhPJymhCb8+adtmqlgsuAxsyUXeg3vOV/bRVZzi9wBHWjkqTj0A6AdeBSSxDHabNoMiIbDMcdDvg== X-Received: by 2002:adf:e9c9:: with SMTP id l9mr32872343wrn.85.1622040549363; Wed, 26 May 2021 07:49:09 -0700 (PDT) Received: from dell ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id t204sm7201207wmg.38.2021.05.26.07.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 May 2021 07:49:08 -0700 (PDT) Date: Wed, 26 May 2021 15:49:07 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Support Opensource , Bartlomiej Zolnierkiewicz , Tony Lindgren , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.cirrus.com, Charles Keepax Subject: Re: [RESEND PATCH v2 06/13] mfd: wm831x: Correct kerneldoc Message-ID: <20210526144907.GC543307@dell> References: <20210526124711.33223-1-krzysztof.kozlowski@canonical.com> <20210526124711.33223-7-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210526124711.33223-7-krzysztof.kozlowski@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 May 2021, Krzysztof Kozlowski wrote: 65;6200;1c > Correct kerneldoc function name to fix W=1 warning: > > drivers/mfd/wm831x-core.c:121: warning: > expecting prototype for wm831x_reg_unlock(). Prototype was for wm831x_reg_lock() instead > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Charles Keepax > > --- > > Changes since v1: > 1. Add Ack > --- > drivers/mfd/wm831x-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This one has been fixed already: https://lore.kernel.org/lkml/20210520120820.3465562-2-lee.jones@linaro.org/ > diff --git a/drivers/mfd/wm831x-core.c b/drivers/mfd/wm831x-core.c > index bcef08f58fb3..c31809b17547 100644 > --- a/drivers/mfd/wm831x-core.c > +++ b/drivers/mfd/wm831x-core.c > @@ -109,7 +109,7 @@ static int wm831x_reg_locked(struct wm831x *wm831x, unsigned short reg) > } > > /** > - * wm831x_reg_unlock: Unlock user keyed registers > + * wm831x_reg_lock: Unlock user keyed registers > * > * The WM831x has a user key preventing writes to particularly > * critical registers. This function locks those registers, -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog