From: riteshh <riteshh@linux.ibm.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Remy Card <card@masi.ibp.fr>,
"David S. Miller" <davem@caip.rutgers.edu>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/1] fs: ext4: namei: trivial: Fix a couple of small whitespace issues
Date: Thu, 27 May 2021 08:41:34 +0530 [thread overview]
Message-ID: <20210527031134.zqewpd2tqo7umoho@riteshh-domain> (raw)
In-Reply-To: <20210520125558.3476318-1-lee.jones@linaro.org>
On 21/05/20 01:55PM, Lee Jones wrote:
Hi Lee,
Thanks for your patch. I see we could a little better here.
There are several other checkpatch ERROR msgs in this file.
Care to fix all of those ERRORS within the same patch itself?
./scripts/checkpatch.pl -f fs/ext4/namei.c | sed -n '/ERROR/,/^$/p'
e.g. to list a few of them -
ERROR: do not use assignment in if condition
#1605: FILE: fs/ext4/namei.c:1605:
+ if ((bh = bh_use[ra_ptr++]) == NULL)
ERROR: space required after that ',' (ctx:VxV)
#1902: FILE: fs/ext4/namei.c:1902:
+ struct buffer_head **bh,struct dx_frame *frame,
^
ERROR: space required after that ',' (ctx:VxV)
#2249: FILE: fs/ext4/namei.c:2249:
+ de = do_split(handle,dir, &bh2, frame, &fname->hinfo);
^
ERROR: spaces required around that '=' (ctx:VxV)
#2288: FILE: fs/ext4/namei.c:2288:
+ int dx_fallback=0;
-ritesh
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> Cc: Remy Card <card@masi.ibp.fr>
> Cc: "David S. Miller" <davem@caip.rutgers.edu>
> Cc: linux-ext4@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> fs/ext4/namei.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index afb9d05a99bae..7e780cf311c5a 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -1899,7 +1899,7 @@ static struct ext4_dir_entry_2 *dx_pack_dirents(struct inode *dir, char *base,
> * Returns pointer to de in block into which the new entry will be inserted.
> */
> static struct ext4_dir_entry_2 *do_split(handle_t *handle, struct inode *dir,
> - struct buffer_head **bh,struct dx_frame *frame,
> + struct buffer_head **bh, struct dx_frame *frame,
> struct dx_hash_info *hinfo)
> {
> unsigned blocksize = dir->i_sb->s_blocksize;
> @@ -2246,7 +2246,7 @@ static int make_indexed_dir(handle_t *handle, struct ext4_filename *fname,
> if (retval)
> goto out_frames;
>
> - de = do_split(handle,dir, &bh2, frame, &fname->hinfo);
> + de = do_split(handle, dir, &bh2, frame, &fname->hinfo);
> if (IS_ERR(de)) {
> retval = PTR_ERR(de);
> goto out_frames;
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-05-27 3:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 12:55 [PATCH 1/1] fs: ext4: namei: trivial: Fix a couple of small whitespace issues Lee Jones
2021-05-27 3:11 ` riteshh [this message]
2021-05-27 8:23 ` Lee Jones
2021-07-22 11:35 ` Lee Jones
2021-07-22 22:17 ` Theodore Ts'o
2021-07-23 7:25 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527031134.zqewpd2tqo7umoho@riteshh-domain \
--to=riteshh@linux.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=card@masi.ibp.fr \
--cc=davem@caip.rutgers.edu \
--cc=lee.jones@linaro.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).