From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4875BC4707F for ; Thu, 27 May 2021 08:23:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26D5561248 for ; Thu, 27 May 2021 08:23:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235445AbhE0IY4 (ORCPT ); Thu, 27 May 2021 04:24:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235359AbhE0IYz (ORCPT ); Thu, 27 May 2021 04:24:55 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 502A3C061574 for ; Thu, 27 May 2021 01:23:21 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id f75-20020a1c1f4e0000b0290171001e7329so1971677wmf.1 for ; Thu, 27 May 2021 01:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=43EyW5t8QfuvIRH8wC3AegWTcYZjbOc3TBDwp+clb3A=; b=dnvTIhAq8y74Gvyi5lJrY+u21ePXWeZMnvlCeRqCfcUBVFag6aopPIZK8vyVl+bJw8 cmSV0vlEGj5E5HPLqkDjS4zHBkqjEfx8neBmiOiXtQStTEWpTctAqqqVr8mDUECZqXRD I29WhIzfssITgSquYB0x1+wOuMwOXMLFH0w2W684faGNaQFxea5dblJzj6iEkCVGdRcu kWy5WHS6uHySy1wNy4gZZDqWymWaF1jqOmITHs3A2YTxVEKKOF0wxyebwoRkVSXxaNx7 zdt+lwCRVCmA1p15wsKjWWUJtwURf2SL12jadmHKVMFU7vTYrmTfzPctdpJXPGnk1YGd R/BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=43EyW5t8QfuvIRH8wC3AegWTcYZjbOc3TBDwp+clb3A=; b=ZuvT8fpX29PSIWLrcSp5uxbxUZV90LC893lQKpg3YsJgJOyDlh9/hNpJowvGtFZCxJ qXPTyZyYW5NSMJhsx8W43U784CRiKS1t8pu1FA03i+L5FvMUZovdJQs9A6MI8L81MAKF l5lhlrCpLJ0UimCZZCR2ARKH5cYAQVarf81nRqtVKesmewbNxcHw88Djamp8PsIFyBEw eLtynnxJ5KmWrU6ZjFoi7mA+sP3ZujyzyGMo2SXb3qswVgzrlk9Cwqlxp024Lyujp7bB D9IkbhI4GUTAfVaNgGnRiUeEqcA+KcQUCFUJ9SDcquK1cm8V029GPdf5tATkTS6nQZks N7Rg== X-Gm-Message-State: AOAM532LrdB2bMtlOFyNt2uHvB3IM+gjXwwCL9mfDGa7xeaiOaayDY2y xmoeacjv5rj+ZUCM+x8Sgpxs4XEMDYkNQA== X-Google-Smtp-Source: ABdhPJxkFXWDgl3F5EEVw0suVP3rVhu42453i5OaMcsvSQ30QC/xJpgr+ClUpXnlQxvb3lbZP32amw== X-Received: by 2002:a1c:a5c3:: with SMTP id o186mr2254998wme.6.1622103799913; Thu, 27 May 2021 01:23:19 -0700 (PDT) Received: from dell ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id a11sm2031588wrr.48.2021.05.27.01.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 01:23:19 -0700 (PDT) Date: Thu, 27 May 2021 09:23:17 +0100 From: Lee Jones To: riteshh Cc: linux-kernel@vger.kernel.org, Theodore Ts'o , Andreas Dilger , Remy Card , "David S. Miller" , linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/1] fs: ext4: namei: trivial: Fix a couple of small whitespace issues Message-ID: <20210527082317.GI543307@dell> References: <20210520125558.3476318-1-lee.jones@linaro.org> <20210527031134.zqewpd2tqo7umoho@riteshh-domain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210527031134.zqewpd2tqo7umoho@riteshh-domain> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 May 2021, riteshh wrote: > On 21/05/20 01:55PM, Lee Jones wrote: > > Hi Lee, > > Thanks for your patch. I see we could a little better here. > There are several other checkpatch ERROR msgs in this file. > Care to fix all of those ERRORS within the same patch itself? I don't think it's a good idea to mix functionality within a single patch. However, I would be happy to provide a follow-up solving these issues for you. > ./scripts/checkpatch.pl -f fs/ext4/namei.c | sed -n '/ERROR/,/^$/p' > > e.g. to list a few of them - > ERROR: do not use assignment in if condition > #1605: FILE: fs/ext4/namei.c:1605: > + if ((bh = bh_use[ra_ptr++]) == NULL) > > ERROR: space required after that ',' (ctx:VxV) > #1902: FILE: fs/ext4/namei.c:1902: > + struct buffer_head **bh,struct dx_frame *frame, > ^ > > ERROR: space required after that ',' (ctx:VxV) > #2249: FILE: fs/ext4/namei.c:2249: > + de = do_split(handle,dir, &bh2, frame, &fname->hinfo); > ^ > > ERROR: spaces required around that '=' (ctx:VxV) > #2288: FILE: fs/ext4/namei.c:2288: > + int dx_fallback=0; > > -ritesh > > > Cc: "Theodore Ts'o" > > Cc: Andreas Dilger > > Cc: Remy Card > > Cc: "David S. Miller" > > Cc: linux-ext4@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > fs/ext4/namei.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c > > index afb9d05a99bae..7e780cf311c5a 100644 > > --- a/fs/ext4/namei.c > > +++ b/fs/ext4/namei.c > > @@ -1899,7 +1899,7 @@ static struct ext4_dir_entry_2 *dx_pack_dirents(struct inode *dir, char *base, > > * Returns pointer to de in block into which the new entry will be inserted. > > */ > > static struct ext4_dir_entry_2 *do_split(handle_t *handle, struct inode *dir, > > - struct buffer_head **bh,struct dx_frame *frame, > > + struct buffer_head **bh, struct dx_frame *frame, > > struct dx_hash_info *hinfo) > > { > > unsigned blocksize = dir->i_sb->s_blocksize; > > @@ -2246,7 +2246,7 @@ static int make_indexed_dir(handle_t *handle, struct ext4_filename *fname, > > if (retval) > > goto out_frames; > > > > - de = do_split(handle,dir, &bh2, frame, &fname->hinfo); > > + de = do_split(handle, dir, &bh2, frame, &fname->hinfo); > > if (IS_ERR(de)) { > > retval = PTR_ERR(de); > > goto out_frames; > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog