From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ide: Remove unused variable ide_media_proc_fops
Date: Fri, 28 May 2021 00:07:03 +0900 [thread overview]
Message-ID: <20210527150703.GA125782@hyeyoo> (raw)
When compiled with option W=1, compiler complained that
ide_media_proc_fops is unused.
in commit ec7d9c9ce897 ("ide: replace ->proc_fops with ->proc_show"),
changed proc_fops to proc_show. So this is not needed anymore.
Also remove function ide_media_proc_open that is only referenced
by ide_media_proc_fops.
Fixes: ec7d9c9ce897("ide: replace ->proc_fops with ->proc_show")
Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
---
drivers/ide/ide-proc.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/ide/ide-proc.c b/drivers/ide/ide-proc.c
index 15c17f3781ee..34bed14f88c7 100644
--- a/drivers/ide/ide-proc.c
+++ b/drivers/ide/ide-proc.c
@@ -449,19 +449,6 @@ static int ide_media_proc_show(struct seq_file *m, void *v)
return 0;
}
-static int ide_media_proc_open(struct inode *inode, struct file *file)
-{
- return single_open(file, ide_media_proc_show, PDE_DATA(inode));
-}
-
-static const struct file_operations ide_media_proc_fops = {
- .owner = THIS_MODULE,
- .open = ide_media_proc_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
-
static ide_proc_entry_t generic_drive_entries[] = {
{ "driver", S_IFREG|S_IRUGO, ide_driver_proc_show },
{ "identify", S_IFREG|S_IRUSR, ide_identify_proc_show },
--
2.25.1
reply other threads:[~2021-05-27 15:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527150703.GA125782@hyeyoo \
--to=42.hyeyoo@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).