From: <patrice.chotard@foss.st.com> To: Mark Brown <broonie@kernel.org>, Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com>, Boris Brezillon <boris.brezillon@collabora.com>, <linux-mtd@lists.infradead.org>, Alexandre Torgue <alexandre.torgue@foss.st.com>, <linux-spi@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Cc: <patrice.chotard@foss.st.com>, <christophe.kerello@foss.st.com> Subject: [PATCH v3 1/3] mtd: spinand: Add spinand_block_unlock() helper Date: Thu, 27 May 2021 18:12:50 +0200 [thread overview] Message-ID: <20210527161252.16620-2-patrice.chotard@foss.st.com> (raw) In-Reply-To: <20210527161252.16620-1-patrice.chotard@foss.st.com> From: Patrice Chotard <patrice.chotard@foss.st.com> Put code responsible of block unlocking in spinand_block_unlock(). This function will be needed by the future SPI-NAND resume ops. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- drivers/mtd/nand/spi/core.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index 17f63f95f4a2..095742e5bc2b 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -1074,12 +1074,30 @@ static int spinand_detect(struct spinand_device *spinand) return 0; } +static int spinand_block_unlock(struct spinand_device *spinand) +{ + struct nand_device *nand = spinand_to_nand(spinand); + int ret = 0, i; + + for (i = 0; i < nand->memorg.ntargets; i++) { + ret = spinand_select_target(spinand, i); + if (ret) + return ret; + + ret = spinand_lock_block(spinand, BL_ALL_UNLOCKED); + if (ret) + return ret; + } + + return ret; +} + static int spinand_init(struct spinand_device *spinand) { struct device *dev = &spinand->spimem->spi->dev; struct mtd_info *mtd = spinand_to_mtd(spinand); struct nand_device *nand = mtd_to_nanddev(mtd); - int ret, i; + int ret; /* * We need a scratch buffer because the spi_mem interface requires that @@ -1137,15 +1155,9 @@ static int spinand_init(struct spinand_device *spinand) } /* After power up, all blocks are locked, so unlock them here. */ - for (i = 0; i < nand->memorg.ntargets; i++) { - ret = spinand_select_target(spinand, i); - if (ret) - goto err_manuf_cleanup; - - ret = spinand_lock_block(spinand, BL_ALL_UNLOCKED); - if (ret) - goto err_manuf_cleanup; - } + ret = spinand_block_unlock(spinand); + if (ret) + goto err_manuf_cleanup; ret = nanddev_init(nand, &spinand_ops, THIS_MODULE); if (ret) -- 2.17.1
next prev parent reply other threads:[~2021-05-27 16:14 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-27 16:12 [PATCH v3 0/3] mtd: spinand: add SPI-NAND MTD resume handler patrice.chotard 2021-05-27 16:12 ` patrice.chotard [this message] 2021-05-27 16:12 ` [PATCH v3 2/3] mtd: spinand: add spinand_read_cfg() helper patrice.chotard 2021-05-27 16:12 ` [PATCH v3 3/3] mtd: spinand: add SPI-NAND MTD resume handler patrice.chotard 2021-05-27 16:23 ` Miquel Raynal 2021-05-28 8:22 ` Patrice CHOTARD 2021-05-28 12:05 ` Pratyush Yadav 2021-05-28 12:51 ` Patrice CHOTARD 2021-05-28 13:17 ` Pratyush Yadav 2021-05-28 14:31 ` Patrice CHOTARD
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210527161252.16620-2-patrice.chotard@foss.st.com \ --to=patrice.chotard@foss.st.com \ --cc=alexandre.torgue@foss.st.com \ --cc=boris.brezillon@collabora.com \ --cc=broonie@kernel.org \ --cc=christophe.kerello@foss.st.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=miquel.raynal@bootlin.com \ --cc=vigneshr@ti.com \ --subject='Re: [PATCH v3 1/3] mtd: spinand: Add spinand_block_unlock() helper' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).