From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CADCC47087 for ; Fri, 28 May 2021 09:55:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1D83613DD for ; Fri, 28 May 2021 09:55:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235818AbhE1J5L (ORCPT ); Fri, 28 May 2021 05:57:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229774AbhE1J5K (ORCPT ); Fri, 28 May 2021 05:57:10 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71628C061574 for ; Fri, 28 May 2021 02:55:35 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id n4so2695428wrw.3 for ; Fri, 28 May 2021 02:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=BcIOldmZVwSiwDw5G4va3pjEdcv7Dn7tcdn9Gsx873k=; b=NShNNzK+tzFi2lVVD7YpraXxGazLcNhejUQVT42SHnmLZZapqZRt1HeA7cF2WCgcby dIZqalfzWp6WJGL/edhrQqYKfOKuoiZBe5NhMAfPyT0JoX8vDeoEsrE7Rg55Kc8dSba/ sEktiKVk1ho6Zb+XFKva1yBpnw/S0RJ+634Y7dhGsNXtrfGkvOzcsu0GGehXev7XQ4Am IYVCB64rDF4go5EI1gm4Gagy1VPsZ5/Pi7dBKrma/vTt8EwClxGuL+4cxA4yE3kdqQ0O ragKANk3RBDm6Rueil7O75K70q08qUNZJV3M+Im3ev8RRSoLCcYuAcdj0UDdSVOX+BS/ uOxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=BcIOldmZVwSiwDw5G4va3pjEdcv7Dn7tcdn9Gsx873k=; b=by6ir0y35J81fIzeNbadcqwYOeMwyoTHvH668Sxk3l2DRGUsnNi+2C9YDQ4o0BOXLp Li9KdVklCJsUufuX3xLTUAd6bnlR5WA5Al9+27fdLOMiNr4+BL4LnorsUffH3z5F2j34 7iRSYR/qLfcvmq4FXCX2lGxiUBmYqFow6z0+gVGwP06EXOx0gaAjMCO34fHPUclVguH+ wzbEwACJjShxTzq41H8P8shE6kOEZmKQ7Ps+Xpgn2fT6HXydDkfJr+YNqjh335/nR09F /ElsM8yrmZH+Mnxmq4j1P/ESyZRkRwhwmaJwJXljMW6dH3WSZt+rEvwOsmDeOh9czGOO mjcA== X-Gm-Message-State: AOAM5334xePhQiiDyhH1aYTJaHP61RE0fqFv6+osjGYLPE6oPxBjpYuw z4kI9CXenGsNvy0MECOE8j+Hzw== X-Google-Smtp-Source: ABdhPJxXMogHhPAuwHe17CWdC9Gbz06ZehTeoTb1h0hwDnX6aajY8pPoEU9vUz9NEdq+bEyB9KXQkg== X-Received: by 2002:a05:6000:1081:: with SMTP id y1mr7621791wrw.34.1622195733890; Fri, 28 May 2021 02:55:33 -0700 (PDT) Received: from dell ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id s5sm6620676wrw.95.2021.05.28.02.55.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 02:55:33 -0700 (PDT) Date: Fri, 28 May 2021 10:55:31 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, Pavel Machek , linux-leds@vger.kernel.org Subject: Re: [PATCH 02/15] leds: leds-gpio-register: Supply description for param 'id' Message-ID: <20210528095531.GO543307@dell> References: <20210528090629.1800173-1-lee.jones@linaro.org> <20210528090629.1800173-3-lee.jones@linaro.org> <20210528094118.xw53q46i676wx6gb@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210528094118.xw53q46i676wx6gb@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 May 2021, Uwe Kleine-König wrote: > Hello Lee, > > On Fri, May 28, 2021 at 10:06:16AM +0100, Lee Jones wrote: > > diff --git a/drivers/leds/leds-gpio-register.c b/drivers/leds/leds-gpio-register.c > > index b9187e71e0cf2..de3f12c2b80d7 100644 > > --- a/drivers/leds/leds-gpio-register.c > > +++ b/drivers/leds/leds-gpio-register.c > > @@ -11,6 +11,7 @@ > > /** > > * gpio_led_register_device - register a gpio-led device > > * @pdata: the platform data used for the new device > > + * @id: platform ID > > * > > Given that id is the first parameter and pdata the second I suggest to > swap the order here and describe id first. That's super picky. I can do it as a follow-up patch if you *really* care about it. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog