From: Alan Stern <stern@rowland.harvard.edu>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, Saravana Kannan <saravanak@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Tony Lindgren <tony@atomide.com>,
Kevin Hilman <khilman@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] PM: runtime: Allow unassigned ->runtime_suspend|resume callbacks
Date: Fri, 28 May 2021 11:27:19 -0400 [thread overview]
Message-ID: <20210528152719.GA1473569@rowland.harvard.edu> (raw)
In-Reply-To: <20210528091202.11603-1-ulf.hansson@linaro.org>
On Fri, May 28, 2021 at 11:12:02AM +0200, Ulf Hansson wrote:
> We are currently allowing ->rpm_idle() callbacks to be unassigned without
> returning an error code from rpm_idle(). This has been useful to avoid
> boilerplate code in drivers. Let's take this approach a step further, by
> allowing unassigned ->runtime_suspend|resume() callbacks as well.
>
> In this way, a consumer/supplier device link can be used to let a consumer
> device be power managed through its supplier device, without requiring
> assigned ->runtime_suspend|resume() callbacks for the consumer device, for
> example.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/base/power/runtime.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
> index 68bebbf81347..8a66eaf731e4 100644
> --- a/drivers/base/power/runtime.c
> +++ b/drivers/base/power/runtime.c
> @@ -345,7 +345,7 @@ static void rpm_suspend_suppliers(struct device *dev)
> static int __rpm_callback(int (*cb)(struct device *), struct device *dev)
> __releases(&dev->power.lock) __acquires(&dev->power.lock)
> {
> - int retval, idx;
> + int retval = 0, idx;
> bool use_links = dev->power.links_count > 0;
>
> if (dev->power.irq_safe) {
> @@ -373,7 +373,8 @@ static int __rpm_callback(int (*cb)(struct device *), struct device *dev)
> }
> }
>
> - retval = cb(dev);
> + if (cb)
> + retval = cb(dev);
>
> if (dev->power.irq_safe) {
> spin_lock(&dev->power.lock);
> @@ -484,9 +485,6 @@ static int rpm_callback(int (*cb)(struct device *), struct device *dev)
> {
> int retval;
>
> - if (!cb)
> - return -ENOSYS;
This is a change in behavior, right? What about drivers or subsystems
that don't support runtime PM and consequently don't have any RPM
callbacks assigned?
Also, assuming Rafael accepts this change, don't you also need to update
the runtime-PM documentation?
Alan Stern
> -
> if (dev->power.memalloc_noio) {
> unsigned int noio_flag;
>
> --
> 2.25.1
next prev parent reply other threads:[~2021-05-28 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 9:12 [PATCH 2/2] PM: runtime: Allow unassigned ->runtime_suspend|resume callbacks Ulf Hansson
2021-05-28 15:27 ` Alan Stern [this message]
2021-05-31 7:08 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528152719.GA1473569@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=adrian.hunter@intel.com \
--cc=geert+renesas@glider.be \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=saravanak@google.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).