From: Masami Hiramatsu <mhiramat@kernel.org>
To: menglong8.dong@gmail.com
Cc: mcgrof@kernel.org, josh@joshtriplett.org,
viro@zeniv.linux.org.uk, keescook@chromium.org,
samitolvanen@google.com, ojeda@kernel.org, johan@kernel.org,
bhelgaas@google.com, masahiroy@kernel.org,
dong.menglong@zte.com.cn, joe@perches.com, axboe@kernel.dk,
hare@suse.de, jack@suse.cz, tj@kernel.org,
gregkh@linuxfoundation.org, song@kernel.org, neilb@suse.de,
akpm@linux-foundation.org, f.fainelli@gmail.com, arnd@arndb.de,
linux@rasmusvillemoes.dk, wangkefeng.wang@huawei.com,
brho@google.com, mhiramat@kernel.org, rostedt@goodmis.org,
vbabka@suse.cz, glider@google.com, pmladek@suse.com,
chris@chrisdown.name, ebiederm@xmission.com, jojing64@gmail.com,
terrelln@fb.com, geert@linux-m68k.org, mingo@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
jeyu@kernel.org
Subject: Re: [PATCH v2 0/3] init/initramfs.c: make initramfs support pivot_root
Date: Fri, 28 May 2021 16:10:12 +0900 [thread overview]
Message-ID: <20210528161012.c9c8e25db29df3dbc142c62e@kernel.org> (raw)
In-Reply-To: <20210525141524.3995-1-dong.menglong@zte.com.cn>
Hi,
On Tue, 25 May 2021 22:15:21 +0800
menglong8.dong@gmail.com wrote:
> From: Menglong Dong <dong.menglong@zte.com.cn>
>
> As Luis Chamberlain suggested, I split the patch:
> [init/initramfs.c: make initramfs support pivot_root]
> (https://lore.kernel.org/linux-fsdevel/20210520154244.20209-1-dong.menglong@zte.com.cn/)
> into three.
>
> The goal of the series patches is to make pivot_root() support initramfs.
>
> In the first patch, I introduce the function ramdisk_exec_exist(), which
> is used to check the exist of 'ramdisk_execute_command' in LOOKUP_DOWN
> lookup mode.
>
> In the second patch, I create a second mount, which is called
> 'user root', and make it become the root. Therefore, the root has a
> parent mount, and it can be umounted or pivot_root.
>
> In the third patch, I fix rootfs_fs_type with ramfs, as it is not used
> directly any more, and it make no sense to switch it between ramfs and
> tmpfs, just fix it with ramfs to simplify the code.
This idea sounds good to me. I have tested it with MINCS container shell
script (https://github.com/mhiramat/mincs).
However, I found different issue on init_eaccess() (or symlink lookup)
with this series.
I'm using a busybox initramfs, and it makes /init as a symlink of "/sbin/init"
(absolute path)
When CONFIG_INITRAMFS_USER_ROOT=n, it booted. But CONFIG_INITRAMFS_USER_ROOT=y,
it failed to boot because it failed to find /init. If I made the /init as
a symlink of "sbin/init" (relative path), it works.
Would you have any idea?
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-05-28 7:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 14:15 [PATCH v2 0/3] init/initramfs.c: make initramfs support pivot_root menglong8.dong
2021-05-25 14:15 ` [PATCH v2 1/3] init/main.c: introduce function ramdisk_exec_exist() menglong8.dong
2021-05-25 14:15 ` [PATCH v2 2/3] init/do_cmounts.c: introduce 'user_root' for initramfs menglong8.dong
2021-05-25 18:49 ` Eric W. Biederman
2021-05-26 1:51 ` Menglong Dong
2021-05-26 3:23 ` Eric W. Biederman
2021-05-26 4:32 ` Josh Triplett
2021-05-26 8:33 ` Menglong Dong
2021-05-26 9:03 ` Luis Chamberlain
2021-05-27 7:29 ` Menglong Dong
2021-05-26 22:33 ` Josh Triplett
2021-05-26 8:23 ` Menglong Dong
2021-05-25 14:15 ` [PATCH v2 3/3] init/do_mounts.c: fix rootfs_fs_type with ramfs menglong8.dong
2021-05-25 17:43 ` [PATCH v2 0/3] init/initramfs.c: make initramfs support pivot_root Josh Triplett
2021-05-28 7:10 ` Masami Hiramatsu [this message]
2021-05-28 7:37 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528161012.c9c8e25db29df3dbc142c62e@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=brho@google.com \
--cc=chris@chrisdown.name \
--cc=dong.menglong@zte.com.cn \
--cc=ebiederm@xmission.com \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=johan@kernel.org \
--cc=jojing64@gmail.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=mingo@kernel.org \
--cc=neilb@suse.de \
--cc=ojeda@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=song@kernel.org \
--cc=terrelln@fb.com \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).