From: Jarkko Sakkinen <jarkko@kernel.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Alexander Wellbrock <a.wellbrock@mailbox.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Peter Huewe <peterhuewe@gmx.de>,
Peter Robinson <pbrobinson@gmail.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm_tis_spi: add missing SPI device ID entries
Date: Mon, 31 May 2021 08:37:11 +0300 [thread overview]
Message-ID: <20210531053711.hmt4xm2g726d6ime@kernel.org> (raw)
In-Reply-To: <20210527152352.3835076-1-javierm@redhat.com>
On Thu, May 27, 2021 at 05:23:52PM +0200, Javier Martinez Canillas wrote:
> The SPI core always reports a "MODALIAS=spi:<foo>", even if the device was
> registered via OF. This means that this module won't auto-load if a DT has
> for example has a node with a compatible "infineon,slb9670" string.
>
> In that case kmod will expect a "MODALIAS=of:N*T*Cinfineon,slb9670" uevent
> but instead will get a "MODALIAS=spi:slb9670", which is not present in the
> kernel module aliases:
>
> $ modinfo drivers/char/tpm/tpm_tis_spi.ko | grep alias
> alias: of:N*T*Cgoogle,cr50C*
> alias: of:N*T*Cgoogle,cr50
> alias: of:N*T*Ctcg,tpm_tis-spiC*
> alias: of:N*T*Ctcg,tpm_tis-spi
> alias: of:N*T*Cinfineon,slb9670C*
> alias: of:N*T*Cinfineon,slb9670
> alias: of:N*T*Cst,st33htpm-spiC*
> alias: of:N*T*Cst,st33htpm-spi
> alias: spi:cr50
> alias: spi:tpm_tis_spi
> alias: acpi*:SMO0768:*
>
> To workaround this issue, add in the SPI device ID table all the entries
> that are present in the OF device ID table.
>
> Reported-by: Alexander Wellbrock <a.wellbrock@mailbox.org>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
>
> drivers/char/tpm/tpm_tis_spi_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
> index 3856f6ebcb3..de4209003a4 100644
> --- a/drivers/char/tpm/tpm_tis_spi_main.c
> +++ b/drivers/char/tpm/tpm_tis_spi_main.c
> @@ -260,6 +260,8 @@ static int tpm_tis_spi_remove(struct spi_device *dev)
> }
>
> static const struct spi_device_id tpm_tis_spi_id[] = {
> + { "st33htpm-spi", (unsigned long)tpm_tis_spi_probe },
> + { "slb9670", (unsigned long)tpm_tis_spi_probe },
> { "tpm_tis_spi", (unsigned long)tpm_tis_spi_probe },
> { "cr50", (unsigned long)cr50_spi_probe },
> {}
> --
> 2.31.1
>
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
/Jarkko
prev parent reply other threads:[~2021-05-31 5:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 15:23 [PATCH] tpm_tis_spi: add missing SPI device ID entries Javier Martinez Canillas
2021-05-27 16:11 ` Jason Gunthorpe
2021-05-27 16:42 ` Javier Martinez Canillas
2021-05-28 16:54 ` Jason Gunthorpe
2021-05-29 13:50 ` Peter Robinson
2021-05-31 5:37 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531053711.hmt4xm2g726d6ime@kernel.org \
--to=jarkko@kernel.org \
--cc=a.wellbrock@mailbox.org \
--cc=javierm@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbrobinson@gmail.com \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).