From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Hugh Dickins <hughd@google.com>
Cc: Yang Shi <shy828301@gmail.com>,
willy@infradead.org, jhubbard@nvidia.com,
kirill.shutemov@linux.intel.com, vbabka@suse.cz,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mm: dump_page: print total mapcount for compound page
Date: Mon, 31 May 2021 11:19:02 +0300 [thread overview]
Message-ID: <20210531081902.nm3lsw2lp3utrafy@box> (raw)
In-Reply-To: <alpine.LSU.2.11.2105281222500.22433@eggly.anvils>
On Fri, May 28, 2021 at 12:47:31PM -0700, Hugh Dickins wrote:
> > page if possible. But how to implement it safely seems controversial.
> > Some ideas and potential problems have been discussed by
> > https://lore.kernel.org/linux-mm/alpine.LSU.2.11.2105261733110.16920@eggly.anvils/.
> >
> > So I prepared this patch to show a possible approach to get some
> > feedback. The same thing could be decoded by the reader of page dump
> > as well by using the same formula used by this patch. However it sounds
> > more convenient to have kernel do the math.
> >
> > mm/debug.c | 35 +++++++++++++++++++++++++++++------
> > 1 file changed, 29 insertions(+), 6 deletions(-)
>
> Adding that code to come up with a deceptive approximation to a number
> which most sites won't care about: speaking for me, I'll say no.
I agree. The approximation may bring more confusion than help debugging.
--
Kirill A. Shutemov
prev parent reply other threads:[~2021-05-31 8:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 17:54 [RFC PATCH] mm: dump_page: print total mapcount for compound page Yang Shi
2021-05-28 18:22 ` Matthew Wilcox
2021-05-28 18:56 ` Yang Shi
2021-05-28 18:26 ` John Hubbard
2021-05-28 19:03 ` Yang Shi
2021-05-28 19:59 ` John Hubbard
2021-05-28 19:47 ` Hugh Dickins
2021-05-31 8:19 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531081902.nm3lsw2lp3utrafy@box \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).