archive mirror
 help / color / mirror / Atom feed
From: Riccardo Mancini <>
To: Arnaldo Carvalho de Melo <>,
	Namhyung Kim <>,
	Ian Rogers <>
Cc: Riccardo Mancini <>,
	Peter Zijlstra <>,
	Ingo Molnar <>,
	Mark Rutland <>,
	Alexander Shishkin <>,
	Jiri Olsa <>,,
Subject: [PATCH] perf: fix segfault when wrong option for --debug is provided
Date: Mon, 31 May 2021 23:28:28 +0200	[thread overview]
Message-ID: <> (raw)

The command `perf --debug record` causes a segfault instead of notifying
the user of the unrecognized option for --debug (the correct syntax would
be `perf --debug verbose=2 record`).

The bug is caused by a call to pr_err before debug_file (debug.c:34) is
set via perf_debug_setup(). It has been introduced in
commit 8abceacff87d ("perf debug: Add debug_set_file function").

This patch resolves the bug by calling perf_debug_setup earlier in the
main, so that debug_file is set to stderr before any call to a debug
printing function is made.

Signed-off-by: Riccardo Mancini <>
 tools/perf/perf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/perf.c b/tools/perf/perf.c
index 20cb91ef06ffc..cffbab2d085a7 100644
--- a/tools/perf/perf.c
+++ b/tools/perf/perf.c
@@ -448,6 +448,7 @@ int main(int argc, const char **argv)
+	perf_debug_setup();
 	cmd = extract_argv0_path(argv[0]);
 	if (!cmd)
@@ -531,8 +532,6 @@ int main(int argc, const char **argv)
-	perf_debug_setup();
 	while (1) {
 		static int done_help;

             reply	other threads:[~2021-05-31 21:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31 21:28 Riccardo Mancini [this message]
2021-06-01 13:37 ` [PATCH] perf: fix segfault when wrong option for --debug is provided Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).