From: kernel test robot <lkp@intel.com>
To: John Ogness <john.ogness@linutronix.de>, Petr Mladek <pmladek@suse.com>
Cc: kbuild-all@lists.01.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: [PATCH next v1 1/2] dump_stack: move cpu lock to printk.c
Date: Tue, 1 Jun 2021 04:04:31 +0800 [thread overview]
Message-ID: <202106010359.YVNT2JXk-lkp@intel.com> (raw)
In-Reply-To: <20210531162051.2325-2-john.ogness@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2771 bytes --]
Hi John,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20210528]
url: https://github.com/0day-ci/linux/commits/John-Ogness/introduce-printk-cpu-lock/20210601-013122
base: 3e029760e6f8ce90c122c267a039ae73b3f1f5a4
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/528abf3d0ab80471d02f4f16cbe97b2eaa918a11
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review John-Ogness/introduce-printk-cpu-lock/20210601-013122
git checkout 528abf3d0ab80471d02f4f16cbe97b2eaa918a11
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
lib/dump_stack.c:97: warning: Function parameter or member 'log_lvl' not described in 'dump_stack_lvl'
>> lib/dump_stack.c:97: warning: expecting prototype for dump_stack(). Prototype was for dump_stack_lvl() instead
vim +97 lib/dump_stack.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 90
196779b9b4ce19 Tejun Heo 2013-04-30 91 /**
196779b9b4ce19 Tejun Heo 2013-04-30 92 * dump_stack - dump the current task information and its stack trace
196779b9b4ce19 Tejun Heo 2013-04-30 93 *
196779b9b4ce19 Tejun Heo 2013-04-30 94 * Architectures can override this implementation by implementing its own.
196779b9b4ce19 Tejun Heo 2013-04-30 95 */
d542aa86de8ad0 Alexander Potapenko 2021-05-26 96 asmlinkage __visible void dump_stack_lvl(const char *log_lvl)
^1da177e4c3f41 Linus Torvalds 2005-04-16 @97 {
528abf3d0ab804 John Ogness 2021-05-31 98 unsigned int cpu_store;
d7ce36924344ac Eric Dumazet 2016-02-05 99 unsigned long flags;
b58d977432c80e Alex Thorlton 2013-07-03 100
528abf3d0ab804 John Ogness 2021-05-31 101 printk_cpu_lock(&cpu_store, &flags);
d542aa86de8ad0 Alexander Potapenko 2021-05-26 102 __dump_stack(log_lvl);
528abf3d0ab804 John Ogness 2021-05-31 103 printk_cpu_unlock(cpu_store, flags);
b58d977432c80e Alex Thorlton 2013-07-03 104 }
d542aa86de8ad0 Alexander Potapenko 2021-05-26 105 EXPORT_SYMBOL(dump_stack_lvl);
d542aa86de8ad0 Alexander Potapenko 2021-05-26 106
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60755 bytes --]
next prev parent reply other threads:[~2021-05-31 20:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 16:20 [PATCH next v1 0/2] introduce printk cpu lock John Ogness
2021-05-31 16:20 ` [PATCH next v1 1/2] dump_stack: move cpu lock to printk.c John Ogness
2021-05-31 16:30 ` John Ogness
2021-05-31 20:04 ` kernel test robot [this message]
2021-05-31 21:49 ` kernel test robot
2021-06-01 2:55 ` Sergey Senozhatsky
2021-06-01 6:58 ` John Ogness
2021-06-01 7:37 ` John Ogness
2021-06-01 13:29 ` Petr Mladek
2021-06-01 13:59 ` Petr Mladek
2021-06-01 14:21 ` John Ogness
2021-06-03 6:33 ` Petr Mladek
2021-05-31 16:20 ` [PATCH next v1 2/2] nmi_backtrace: use the printk cpu lock for show_regs() John Ogness
2021-06-01 14:25 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106010359.YVNT2JXk-lkp@intel.com \
--to=lkp@intel.com \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bristot@redhat.com \
--cc=john.ogness@linutronix.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).