From: Lee Jones <lee.jones@linaro.org>
To: Moriis Ku <saumah@gmail.com>
Cc: linux-kernel@vger.kernel.org, jason_lee@sunix.com, taian.chen@sunix.com
Subject: Re: [PATCH] mfd:Add supprt for SUNIX mfd & PCIe driver
Date: Tue, 1 Jun 2021 10:09:07 +0100 [thread overview]
Message-ID: <20210601090907.GA543307@dell> (raw)
In-Reply-To: <20210528095814.6939-1-saumah@gmail.com>
On Fri, 28 May 2021, Moriis Ku wrote:
> From: Morris Ku <saumah@gmail.com>
>
> Add support for SUNIX mfd & PCIe driver
That's a pretty broad description.
> Cc: Jason Lee <jason_lee@sunix.com>
> Cc: Taian Chen <taian.chen@sunix.com>
> Signed-off-by: Morris Ku <saumah@gmail.com>
> ---
> Kconfig | 12 ++++++++++++
> Makefile | 4 ++++
> 2 files changed, 16 insertions(+)
Patches should be generated from the root of the source directory.
> diff --git a/Kconfig b/Kconfig
> index 17d0ad2..25b7db5 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -2012,6 +2012,18 @@ config RAVE_SP_CORE
> Select this to get support for the Supervisory Processor
> device found on several devices in RAVE line of hardware.
>
> +config MFD_SUNIX_SDC
> + tristate
> + select MFD_CORE
> + select SERIAL_8250_SDC
> +
> +config MFD_SUNIX_SDC_PCI
> + tristate "SUNIX SDC PCIe multi-function board support"
What is SDC?
> + select MFD_SUNIX_SDC
> + depends on X86 && PCI
> + help
> + Selecting this option will add support for SUNIX SDC PCIe
> + multi-function board.
More please.
> endmenu
> endif
> diff --git a/Makefile b/Makefile
> index a1872e4..52fa8be 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -256,4 +256,8 @@ obj-$(CONFIG_MFD_ROHM_BD70528) += rohm-bd70528.o
> obj-$(CONFIG_MFD_ROHM_BD718XX) += rohm-bd718x7.o
> obj-$(CONFIG_MFD_STMFX) += stmfx.o
>
> +obj-$(CONFIG_MFD_SUNIX_SDC) += sdc_mfd.o
There is no such thing as MFD.
You probably mean 'core'.
> +obj-$(CONFIG_MFD_SUNIX_SDC_PCI) += sdc_pci.o
> +
> +
No need for 2 empty spaces.
This patch doesn't actually do anything.
Please submit it squashed into the driver.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-06-01 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 9:58 [PATCH] mfd:Add supprt for SUNIX mfd & PCIe driver Moriis Ku
2021-06-01 9:09 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601090907.GA543307@dell \
--to=lee.jones@linaro.org \
--cc=jason_lee@sunix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saumah@gmail.com \
--cc=taian.chen@sunix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).